-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ci-daily pytest failure #6335
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid interpreting `\` as a path.
Ref: failed ci-daily run https://github.com/quantumlib/Cirq/actions/runs/6700241980 |
For instant workflow verification. Revert this commit before submitting the PR.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6335 +/- ##
=======================================
Coverage 97.83% 97.83%
=======================================
Files 1108 1108
Lines 96240 96266 +26
=======================================
+ Hits 94157 94184 +27
+ Misses 2083 2082 -1
☔ View full report in Codecov by Sentry. |
Fails on Windows due to a different location of Python scripts.
ci-daily passed at https://github.com/quantumlib/Cirq/actions/runs/6712280403 PR trigger for the workflow is not needed anymore. This reverts commit 75fca56.
Note: ci-daily passed for this PR at https://github.com/quantumlib/Cirq/actions/runs/6712280403 |
viathor
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary workaround for #6336