Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change signature of cirq_ft.And gate to use directional registers like Qualtran #6302

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

tanujkhattar
Copy link
Collaborator

After #6300, Cirq-FT registers can now be directional (LEFT / RIGHT). This PR changes the signature of And gate to use directional registers s.t. it matches the signature of And Bloq in Qualtran. This is the only gate right now that should use directional signatures in Cirq-FT.

cc @fdmalone @mpharrigan

@tanujkhattar tanujkhattar requested review from cduck and a team as code owners September 25, 2023 22:47
@tanujkhattar tanujkhattar changed the title Change signature of gate to use directional registers like Qualtran Change signature of cirq_ft.And gate to use directional registers like Qualtran Sep 25, 2023
@CirqBot CirqBot added the size: M 50< lines changed <250 label Sep 25, 2023
@tanujkhattar tanujkhattar added area/cirq-ft Issues related to the Cirq-FT sub-package BREAKING CHANGE For pull requests that are important to mention in release notes. labels Sep 25, 2023
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (8e4e7d1) 97.88% compared to head (0db23c0) 97.89%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6302   +/-   ##
=======================================
  Coverage   97.88%   97.89%           
=======================================
  Files        1104     1104           
  Lines       95863    95878   +15     
=======================================
+ Hits        93840    93856   +16     
+ Misses       2023     2022    -1     
Files Coverage Δ
cirq-ft/cirq_ft/__init__.py 100.00% <ø> (ø)
cirq-ft/cirq_ft/algos/and_gate.py 100.00% <100.00%> (ø)
cirq-ft/cirq_ft/algos/and_gate_test.py 100.00% <100.00%> (ø)
cirq-ft/cirq_ft/algos/apply_gate_to_lth_target.py 100.00% <100.00%> (ø)
...-ft/cirq_ft/algos/apply_gate_to_lth_target_test.py 100.00% <100.00%> (ø)
cirq-ft/cirq_ft/algos/arithmetic_gates.py 99.08% <100.00%> (ø)
cirq-ft/cirq_ft/algos/generic_select_test.py 100.00% <100.00%> (ø)
cirq-ft/cirq_ft/algos/hubbard_model.py 98.21% <100.00%> (ø)
cirq-ft/cirq_ft/algos/hubbard_model_test.py 100.00% <100.00%> (ø)
...q_ft/algos/mean_estimation/complex_phase_oracle.py 100.00% <100.00%> (ø)
... and 32 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mpharrigan mpharrigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tanujkhattar tanujkhattar merged commit 1948e73 into quantumlib:master Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cirq-ft Issues related to the Cirq-FT sub-package BREAKING CHANGE For pull requests that are important to mention in release notes. size: M 50< lines changed <250
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants