Fix matplotlib typing #6290
Merged
Fix matplotlib typing #6290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matplotlib 3.8.0 was released this week and included typing hints. This fixes the resulting CI breakages.
dstrain115
requested review from
mrwojtek,
vtomole,
cduck,
a team,
wcourtney and
verult
as code owners
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6290 +/- ##
=======================================
Coverage 97.88% 97.88%
=======================================
Files 1104 1104
Lines 95830 95841 +11
=======================================
+ Hits 93805 93818 +13
+ Misses 2025 2023 -2
☔ View full report in Codecov by Sentry. |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
tanujkhattar
approved these changes
Sep 18, 2023
mpharrigan
reviewed
Oct 9, 2023
| @@ -381,6 +383,7 @@ def plot( | |||
| show_plot = not ax | |||
| if not ax: | |||
| fig, ax = plt.subplots(figsize=(8, 8)) | |||
| ax = cast(plt.Axes, ax) | |||
There was a problem hiding this comment.
what does it otherwise think the second return value of plt.sublplots is?
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
* Fix matplotlib typing matplotlib 3.8.0 was released this week and included typing hints. This fixes the resulting CI breakages. * Fix issues. * formatting * Change to seaborn v0_8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
matplotlib 3.8.0 was released this week and included typing hints. This fixes the resulting CI breakages.