Changed FakeQuantumRunStream to support arbitrary response and exception timing #6253
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version of
FakeQuantumRunStream
has the limitation that a response or exception is only fired when it receives a request. This makes it impossible to test these scenarios:This version supports both cases:
reply()
to send a response or raise an exception at any moment.message_id
to one from a different request.With this functionality, it would be possible to write a test for sending requests after breaking a stream, which would have revealed a bug discovered through manual testing.
@maffoo @wcourtney