Engine creator helper function #5658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augustehirth
requested review from
wcourtney,
a team,
vtomole,
cduck and
verult
as code owners
dstrain115
reviewed
Jun 30, 2022
|
Are you going to expose this in the init files as well so that you don't have to specify the whole package? |
|
Great points, ty. I think everything's fixed.. |
mpharrigan
reviewed
Jun 30, 2022
|
API looks nice to me. This could be a good candidate for wrapping in a |
|
@mpharrigan The CI checks are onto the trickery. How to best evade this? |
|
all the test failures are about qiskit??? seems unrelated for coverage: you can add to the block (may have to try exactly where to put it. test with |
|
for the typecheck you can add it to the list of ignored 3rd party modules in mypy.ini edit: or add a type: ignore comment to that line |
mpharrigan
approved these changes
Jul 6, 2022
|
@dstrain115 does this LGTY? |
dstrain115
approved these changes
Jul 6, 2022
augustehirth
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Add a helper function to create a virtual engine with a noisy simulator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a helper function to create a virtual engine with a noisy simulator.