Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Expose GoogleNoiseProperties at top level #5209

Merged
merged 12 commits into from
Apr 22, 2022

Conversation

95-martin-orion
Copy link
Collaborator

Adds GoogleNoiseProperties and related objects to the __init__ files and adds JSON serialization.

This is a follow-up to #5188 to make these classes more convenient to use.

@CirqBot CirqBot added the size: XL lines changed >1000 label Apr 6, 2022
@95-martin-orion 95-martin-orion marked this pull request as ready for review April 22, 2022 15:13
Copy link
Collaborator

@MichaelBroughton MichaelBroughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelBroughton MichaelBroughton self-assigned this Apr 22, 2022
@95-martin-orion 95-martin-orion added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Apr 22, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Apr 22, 2022
@CirqBot CirqBot merged commit 27d77a7 into quantumlib:master Apr 22, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Apr 22, 2022
tonybruguier pushed a commit to tonybruguier/Cirq that referenced this pull request Apr 22, 2022
Adds `GoogleNoiseProperties` and related objects to the `__init__` files and adds JSON serialization.

This is a follow-up to quantumlib#5188 to make these classes more convenient to use.
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
Adds `GoogleNoiseProperties` and related objects to the `__init__` files and adds JSON serialization.

This is a follow-up to quantumlib#5188 to make these classes more convenient to use.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: XL lines changed >1000
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants