-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Expose GoogleNoiseProperties at top level #5209
Merged
CirqBot
merged 12 commits into
quantumlib:master
from
95-martin-orion:cirq-noisegen-3b4a
Apr 22, 2022
Merged
[WIP] Expose GoogleNoiseProperties at top level #5209
CirqBot
merged 12 commits into
quantumlib:master
from
95-martin-orion:cirq-noisegen-3b4a
Apr 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4f54747
to
1f12296
Compare
1f12296
to
4050e76
Compare
MichaelBroughton
approved these changes
Apr 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tonybruguier
pushed a commit
to tonybruguier/Cirq
that referenced
this pull request
Apr 22, 2022
Adds `GoogleNoiseProperties` and related objects to the `__init__` files and adds JSON serialization. This is a follow-up to quantumlib#5188 to make these classes more convenient to use.
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Adds `GoogleNoiseProperties` and related objects to the `__init__` files and adds JSON serialization. This is a follow-up to quantumlib#5188 to make these classes more convenient to use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
GoogleNoiseProperties
and related objects to the__init__
files and adds JSON serialization.This is a follow-up to #5188 to make these classes more convenient to use.