Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compiling: Circuit Transformers API #4483

Closed
vcatherine opened this issue Sep 3, 2021 · 2 comments
Closed

Compiling: Circuit Transformers API #4483

vcatherine opened this issue Sep 3, 2021 · 2 comments
Assignees
@tanujkhattar
Labels
kind/roadmap-item for higher level roadmap items to capture conversations and feedback (not for project tracking)

Comments

@vcatherine
Copy link
Collaborator

vcatherine commented Sep 3, 2021 •
edited by tanujkhattar
Loading

Circuit transformers in Cirq are currently implemented as either a PointOptimizer or independent classes with no common API. The Circuit Transformers API will introduce a common interface for all transformers in Cirq and migrate the existing transformers to this new Interface.

Requirements:

  • Transformer passes should have a uniform API for consistency across the codebase.
  • Transformers should be easily composable s.t. multiple individual transformer passes can be bundled together to form a transformation chain / graph which can be applied to a circuit using a single API call.
  • All Transformers should support a verbose logging mode for easier inspection and understanding of the action of a transformer on the input circuits.

Related

Related issues: Circuit transformer patterns #3237 Circuit transformer organization #3238
@vcatherine vcatherine added the kind/roadmap-item for higher level roadmap items to capture conversations and feedback (not for project tracking) label Sep 3, 2021
@tanujkhattar tanujkhattar mentioned this issue Sep 16, 2021
Open
8 tasks
@tanujkhattar
Copy link
Collaborator

Commenting again here for reference.

RFC: https://tinyurl.com/cirq-circuit-transformers-api

This was referenced Nov 17, 2021
Merged
Merged
@tanujkhattar tanujkhattar mentioned this issue Jan 4, 2022
Merged
CirqBot pushed a commit that referenced this issue Jan 21, 2022
@tanujkhattar
Add Transformer API Interface and @cirq.transformer decorator (#4797)
6119620 
Defines `TRANSFORMER_TYPE` and Implements the `@transformer` decorator, as proposed in https://tinyurl.com/cirq-circuit-transformers-api

All existing transformers will be rewritten to follow the new API once this is checked-in. 
Implementation of `TransformerStatsLoggerBase` will follow in a separate PR. 

Part of #4483

cc @maffoo PTAL at all the mypy magic.
MichaelBroughton pushed a commit to MichaelBroughton/Cirq that referenced this issue Jan 22, 2022
@tanujkhattar @MichaelBroughton
Add Transformer API Interface and @cirq.transformer decorator (quan…
63a5c0b 
…tumlib#4797)

Defines `TRANSFORMER_TYPE` and Implements the `@transformer` decorator, as proposed in https://tinyurl.com/cirq-circuit-transformers-api

All existing transformers will be rewritten to follow the new API once this is checked-in. 
Implementation of `TransformerStatsLoggerBase` will follow in a separate PR. 

Part of quantumlib#4483

cc @maffoo PTAL at all the mypy magic.
This was referenced Jan 24, 2022
Closed
Merged
Merged
Merged
Merged
CirqBot pushed a commit that referenced this issue Jan 31, 2022
@tanujkhattar
Add synchronize_terminal_measurements transformer to replace `Synch…
ab61d7f 
…ronizeTerminalMeasurements` (#4911)

- Part of #4722
- Follows the new Transformer API #4483
- Supports no compile tags NoCompile Tag for optimizers #4253
- Fixes #4907
This was referenced Feb 3, 2022
Merged
Merged
Merged
Merged
Closed
This was referenced Feb 12, 2022
Merged
Closed
Merged
Merged
This was referenced Feb 25, 2022
Merged
Closed
Merged
Merged
CirqBot pushed a commit that referenced this issue Mar 14, 2022
@tanujkhattar
Add cg.SycamoreTargetGateset and deprecate `cg.ConvertToSycamoreGat…
889e5d2 
…es` (#5054)

- Part of #5028
- Follows the new Transformer API #4483
- Supports no compile tags NoCompile Tag for optimizers #4253
@tanujkhattar
Copy link
Collaborator

Migration of optimizers in vendor packages is being tracked as part of roadmap item #3238

The work on transformer API is now complete, including addition of new docs. I'll mark this as closed.

rht pushed a commit to rht/Cirq that referenced this issue May 1, 2023
@tanujkhattar @rht
Add Transformer API Interface and @cirq.transformer decorator (quan…
074610b 
…tumlib#4797)

Defines `TRANSFORMER_TYPE` and Implements the `@transformer` decorator, as proposed in https://tinyurl.com/cirq-circuit-transformers-api

All existing transformers will be rewritten to follow the new API once this is checked-in. 
Implementation of `TransformerStatsLoggerBase` will follow in a separate PR. 

Part of quantumlib#4483

cc @maffoo PTAL at all the mypy magic.
rht pushed a commit to rht/Cirq that referenced this issue May 1, 2023
@tanujkhattar @rht
Add synchronize_terminal_measurements transformer to replace `Synch…
03ddbd8 
…ronizeTerminalMeasurements` (quantumlib#4911)

- Part of quantumlib#4722
- Follows the new Transformer API quantumlib#4483
- Supports no compile tags NoCompile Tag for optimizers quantumlib#4253
- Fixes quantumlib#4907
rht pushed a commit to rht/Cirq that referenced this issue May 1, 2023
@tanujkhattar @rht
Add cg.SycamoreTargetGateset and deprecate `cg.ConvertToSycamoreGat…
f4d1a50 
…es` (quantumlib#5054)

- Part of quantumlib#5028
- Follows the new Transformer API quantumlib#4483
- Supports no compile tags NoCompile Tag for optimizers quantumlib#4253
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this issue Oct 31, 2024
@tanujkhattar
Add Transformer API Interface and @cirq.transformer decorator (quan…
9d267da 
…tumlib#4797)

Defines `TRANSFORMER_TYPE` and Implements the `@transformer` decorator, as proposed in https://tinyurl.com/cirq-circuit-transformers-api

All existing transformers will be rewritten to follow the new API once this is checked-in. 
Implementation of `TransformerStatsLoggerBase` will follow in a separate PR. 

Part of quantumlib#4483

cc @maffoo PTAL at all the mypy magic.
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this issue Oct 31, 2024
@tanujkhattar
Add synchronize_terminal_measurements transformer to replace `Synch…
001acd1 
…ronizeTerminalMeasurements` (quantumlib#4911)

- Part of quantumlib#4722
- Follows the new Transformer API quantumlib#4483
- Supports no compile tags NoCompile Tag for optimizers quantumlib#4253
- Fixes quantumlib#4907
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tanujkhattar tanujkhattar

Labels
kind/roadmap-item for higher level roadmap items to capture conversations and feedback (not for project tracking)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tanujkhattar @95-martin-orion @vcatherine