-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore custom isort
section sorting
#299
Conversation
Preview page for your plugin is ready here: |
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #299 +/- ##
==========================================
+ Coverage 83.92% 84.47% +0.54%
==========================================
Files 30 30
Lines 1904 1932 +28
Branches 295 294 -1
==========================================
+ Hits 1598 1632 +34
+ Misses 219 215 -4
+ Partials 87 85 -2
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Code changes are just from running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great to have the custom isort sections!
Code changes are just from running ruff.
just wondering why the formatting wasn't applied automatically previously? Shouldn't the pr linting checks pick up any changes that would be made? Or is there something else that is being changed here in the configuration apart from the custom isort sections?
There will have been a bug in an earlier version of |
Fixes #249. Once astral-sh/ruff#2419 is released.