-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
some charts don't render correctly on load (but then render correctly when you perturb them) #506
Comments
That seems very odd. I think I know why that happens |
Right now the memoization is kinda hacky. It probably would be good to submit the entire Squiggle string to the FunctionChart, for it to use as one of the keys for memoization. |
This is due to docusaurus rendering all tabs in advance (facebook/docusaurus#3706), and squiggle-components using |
I thought I'd need useMeasure or Resize Observer API to detect when the component appears on screen, but turns out there's a PR incoming. |
Description:
Steps to reproduce:
With Continuous and Discrete
tab)
and re-add it)Expected behavior:
the chart that shows in step 4 should be on load
What I got instead:
chart seems borked.
The text was updated successfully, but these errors were encountered: