-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multilingual IWSLT tst2017 test set is broken #15
Comments
Thank you so much for reminding me,
I will try to fix it asap, especially when recently I went back to this
dataset for some fun things.
Best regards,
Quan
…On Fri, 24 Jan 2020 at 22:28, Stephan Peitz ***@***.***> wrote:
Hi,
just realised that the preprocessed data provided under
https://github.com/quanpn90/NMTGMinor/tree/master/recipes/multilingual-translation
are not correct.
In particular, the test sets tst2017 contain ~3k-4k lines while it should
be ~1.1k.
Furthermore, the references are not correct, e.g. the first ~2k lines of
tst2017.en-de.bpe.de are in English rather than German.
My guess is that you accidentally mixed in tst2010.
You might want to fix that otherwise people could assume you computed your
BLEU scores based on these incorrect test sets.
Cheers,
Stephan
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#15?email_source=notifications&email_token=ADTOFOKBF7RG377OTFTS4RLQ7NMQ3A5CNFSM4KLMK3T2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IIUB3RA>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADTOFOL3ETHCSBDWM7QHHQDQ7NMQ3ANCNFSM4KLMK3TQ>
.
|
Hi Quan, have you been able to fix it? Cheers, |
Hi Stephan, thank you for reminding me. I think I did a terrible mistake for these test sets due to a mistake in preprocessing. Basically the test set 2017 were duplicated (twice) so the BLEU score in the paper is possibly not correct. If you don't mind I will run the translation again because the models are still here and put the correct results here. Sorry for this mistake. |
Hi,
just realised that the preprocessed data provided under https://github.com/quanpn90/NMTGMinor/tree/master/recipes/multilingual-translation are not correct.
In particular, the test sets
tst2017
contain ~3k-4k lines while it should be ~1.1k.Furthermore, the references are not correct, e.g. the first ~2k lines of
tst2017.en-de.bpe.de
are in English rather than German.My guess is that you accidentally mixed in
tst2010
.You might want to fix that otherwise people could assume you computed your BLEU scores based on these incorrect test sets.
Cheers,
Stephan
The text was updated successfully, but these errors were encountered: