Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add KAS configuration in preparation for meta-qcom-hwe style CI #8

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

koenkooi
Copy link
Contributor

This is heavily based on the KAS config from meta-qcom-hwe.git

The meta-qcom layer is locked to a commit that still has initramfs-qcom-image, the build won't start otherwise. This also includes inherits that should not be in the CI config, but in the DISTRO.conf.

@ricardosalveti
Copy link

Do you want to have this in place before moving inherits to distro.conf and fixing the meta-qcom issue?

@ndechesne
Copy link

  1. this is using OE-core+bitbake instead of poky. we need to have this discussion first.
  2. I am slightly worried that we are duplicating all CI files here and in meta-qcom-hwe. Should we have all the CI script in meta-qcom-hwe, and have builds with and without meta-qcom-distro, all managed from there? e.g. add qcom-distro.yml file in meta-qcom-hwe?

@mwasilew
Copy link

Maybe the build part can be done as reusable action/workflow that can be hosted separately and included in the repository workflows? I'm not 100% sure this is possible, but I can spend some time exploring the idea.

@ricardosalveti
Copy link

  1. this is using OE-core+bitbake instead of poky. we need to have this discussion first.

I don't think it makes sense to rely on poky for this repo at least, helps avoiding more confusion as well.

  1. I am slightly worried that we are duplicating all CI files here and in meta-qcom-hwe. Should we have all the CI script in meta-qcom-hwe, and have builds with and without meta-qcom-distro, all managed from there? e.g. add qcom-distro.yml file in meta-qcom-hwe?

We need to also have CI separated for this repo / project alone, and that would not cover this scenario that well.

@ricardosalveti
Copy link

Maybe the build part can be done as reusable action/workflow that can be hosted separately and included in the repository workflows? I'm not 100% sure this is possible, but I can spend some time exploring the idea.

Yeah, that could potentially work.

@ndechesne
Copy link

Maybe the build part can be done as reusable action/workflow that can be hosted separately and included in the repository workflows? I'm not 100% sure this is possible, but I can spend some time exploring the idea.

Yeah, that could potentially work.

yes, that would definitely work.

@ndechesne
Copy link

  1. this is using OE-core+bitbake instead of poky. we need to have this discussion first.

I don't think it makes sense to rely on poky for this repo at least, helps avoiding more confusion as well.

well, what makes sense is to do the same thing on meta-qcom-hwe and meta-qcom-distro. I think.

  1. I am slightly worried that we are duplicating all CI files here and in meta-qcom-hwe. Should we have all the CI script in meta-qcom-hwe, and have builds with and without meta-qcom-distro, all managed from there? e.g. add qcom-distro.yml file in meta-qcom-hwe?

We need to also have CI separated for this repo / project alone, and that would not cover this scenario that well.

Why do we need a separate CI ? we can trigger the meta-qcom-distro for PR and so, and reuse the CI from meta-qcom, no? we cannot build meta-qcom-distro without meta-qcom anyway. So perhaps there is a way we can avoid the duplication.

@ricardosalveti
Copy link

  1. this is using OE-core+bitbake instead of poky. we need to have this discussion first.

I don't think it makes sense to rely on poky for this repo at least, helps avoiding more confusion as well.

well, what makes sense is to do the same thing on meta-qcom-hwe and meta-qcom-distro. I think.

In this case we should probably use bitbake + oe-core + poky on both repos then, just the main poky repo is a bit confusing when you are also testing with another OE distro.

  1. I am slightly worried that we are duplicating all CI files here and in meta-qcom-hwe. Should we have all the CI script in meta-qcom-hwe, and have builds with and without meta-qcom-distro, all managed from there? e.g. add qcom-distro.yml file in meta-qcom-hwe?

We need to also have CI separated for this repo / project alone, and that would not cover this scenario that well.

Why do we need a separate CI ? we can trigger the meta-qcom-distro for PR and so, and reuse the CI from meta-qcom, no? we cannot build meta-qcom-distro without meta-qcom anyway. So perhaps there is a way we can avoid the duplication.

Sure, we can check how to avoid duplication for the CI logic itself (hosting them in meta-qcom), what I'm saying is that it makes sense to run CI jobs just for meta-qcom-distro (separated actions in the end).

@ricardosalveti
Copy link

@koenkooi so let's have the kas stuff for meta-qcom-distro in meta-qcom and the github workflows for this repo here.

@koenkooi
Copy link
Contributor Author

koenkooi commented Feb 7, 2025

@koenkooi so let's have the kas stuff for meta-qcom-distro in meta-qcom and the github workflows for this repo here.

I'll work on having the meta-qcom-distro specific kas stuff in meta-qcom.git.

kas User and others added 4 commits February 10, 2025 15:56
This is heavily based on the KAS config from meta-qcom-hwe.git. The end
goal is to reuse the CI configs from there, but for now create a
distinct set.

Signed-off-by: Koen Kooi <[email protected]>
…eclass

EFI is a combined machine/distro feature, so it needs the DISTRO to
enable it. This has no boot impact for non-EFI machines, the main impact
is that optional EFI tools are now actually built.

The package class change ensures that we keep the current default, so
upstream changes won't affect this DISTRO.

Signed-off-by: Koen Kooi <[email protected]>
Meta-qcom builds without an initramfs, disable it for now to match that.

Signed-off-by: kas User <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants