Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yarn workspaces #78

Closed
ghost opened this issue Sep 20, 2017 · 2 comments · Fixed by #81
Closed

Yarn workspaces #78

ghost opened this issue Sep 20, 2017 · 2 comments · Fixed by #81

Comments

@ghost
Copy link

ghost commented Sep 20, 2017 •
edited by ghost
Loading

Hi, it doesn't work correctly with Yarn workspaces... Here is the issues: yarnpkg/yarn#4503 (same as yarnpkg/yarn#4081). All other apps works fine, they search for node_modules in root dir instead of current dir if they don't find it, but Ember just search it in current dir...
@ghost
Copy link
Author

ghost commented Sep 20, 2017 •
edited by ghost
Loading

I fixed this issue. Right now I need to polish it and I will try to make PR. Seems this is harder than I thought.

@mblackritter
Copy link

Luckily, until this is resolved, the solution is to just remove ember-cli-dependency-checker. 🙃

ef4 added a commit to ef4/ember-cli-dependency-checker that referenced this issue Nov 14, 2017
@ef4
Use correct node_module resolution
6fe4857 
This fixes quaertym#78 and removes a deprecation warning in ember-cli master (`DEPRECATION: An addon is trying to access project.nodeModulesPath. This is not a reliable way to discover npm modules....`).
@ef4 ef4 mentioned this issue Nov 14, 2017
Merged
ef4 added a commit to ef4/ember-cli-dependency-checker that referenced this issue Nov 14, 2017
@ef4
Use correct node_module resolution
ee038c7 
This fixes quaertym#78 and removes a deprecation warning in ember-cli master (`DEPRECATION: An addon is trying to access project.nodeModulesPath. This is not a reliable way to discover npm modules....`).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use correct node_module resolution ef4/ember-cli-dependency-checker
1 participant
@mblackritter