fix: missing optional typing leading to wrong build

quadratic-funding · Mar 21, 2023 · 4dab2e0 · 4dab2e0
1 parent 4e4e1e5
commit 4dab2e0
Show file tree

Hide file tree

Showing 5 changed files with 30 additions and 7 deletions.
diff --git a/packages/actions/src/types/index.ts b/packages/actions/src/types/index.ts
@@ -171,7 +171,7 @@ export type CircuitInputData = {
     description: string
     compiler: CircomCompilerData
     template: SourceTemplateData
-    compilationArtifacts: CompilationArtifacts
+    compilationArtifacts?: CompilationArtifacts
     metadata?: CircuitMetadata
     name?: string
     dynamicThreshold?: number

diff --git a/packages/actions/test/data/generators.ts b/packages/actions/test/data/generators.ts
@@ -121,7 +121,10 @@ export const generateFakeCircuit = (fakeData: CircuitDocumentReferenceAndData):
             potStoragePath: fakeData.data.files?.potStoragePath!,
             r1csBlake2bHash: fakeData.data.files?.r1csBlake2bHash!,
             r1csFilename: fakeData.data.files?.r1csFilename!,
-            r1csStoragePath: fakeData.data.files?.r1csStoragePath!
+            r1csStoragePath: fakeData.data.files?.r1csStoragePath!,
+            wasmBlake2bHash: fakeData.data.files?.wasmBlake2bHash!,
+            wasmFilename: fakeData.data.files?.wasmFilename!,
+            wasmStoragePath: fakeData.data.files?.wasmStoragePath!
         },
         avgTimings: {
             contributionComputation: fakeData.data.avgTimings?.contributionComputation!,

diff --git a/packages/actions/test/data/samples.ts b/packages/actions/test/data/samples.ts
@@ -323,7 +323,11 @@ const fakeCircuitSmallNoContributors = generateFakeCircuit({
             r1csBlake2bHash:
                 "0739198d5578a4bdaeb2fa2a1043a1d9cac988472f97337a0a60c296052b82d6cecb6ae7ce503ab9864bc86a38cdb583f2d33877c41543cbf19049510bca7472",
             r1csFilename: "circuit_small.r1cs",
-            r1csStoragePath: "circuits/circuit_small/circuit_small.r1cs"
+            r1csStoragePath: "circuits/circuit_small/circuit_small.r1cs",
+            wasmBlake2bHash:
+                "00d09469acaba682802bf92df24708cf3d499b759379f959c4b6932b14fe9e6bfccc793c3933eac4a76546171d402cab1ae3ce1b3291dbba8e2fb358d52bd77d",
+            wasmFilename: "circuit_small.wasm",
+            wasmStoragePath: "circuits/circuit_small/circuit_small.wasm"
         },
         avgTimings: {
             contributionComputation: 0,
@@ -380,7 +384,11 @@ const fakeCircuitSmallContributors = generateFakeCircuit({
             r1csBlake2bHash:
                 "0739198d5578a4bdaeb2fa2a1043a1d9cac988472f97337a0a60c296052b82d6cecb6ae7ce503ab9864bc86a38cdb583f2d33877c41543cbf19049510bca7472",
             r1csFilename: "circuit_small.r1cs",
-            r1csStoragePath: "circuits/circuit_small/circuit_small.r1cs"
+            r1csStoragePath: "circuits/circuit_small/circuit_small.r1cs",
+            wasmBlake2bHash:
+                "00d09469acaba682802bf92df24708cf3d499b759379f959c4b6932b14fe9e6bfccc793c3933eac4a76546171d402cab1ae3ce1b3291dbba8e2fb358d52bd77d",
+            wasmFilename: "circuit_small.wasm",
+            wasmStoragePath: "circuits/circuit_small/circuit_small.wasm"
         },
         avgTimings: {
             contributionComputation: 0,
@@ -438,7 +446,11 @@ const fakeCircuitForFinalization = generateFakeCircuit({
             r1csBlake2bHash:
                 "0739198d5578a4bdaeb2fa2a1043a1d9cac988472f97337a0a60c296052b82d6cecb6ae7ce503ab9864bc86a38cdb583f2d33877c41543cbf19049510bca7472",
             r1csFilename: "circuit.r1cs",
-            r1csStoragePath: "circuits/circuit/circuit.r1cs"
+            r1csStoragePath: "circuits/circuit/circuit.r1cs",
+            wasmBlake2bHash:
+                "00d09469acaba682802bf92df24708cf3d499b759379f959c4b6932b14fe9e6bfccc793c3933eac4a76546171d402cab1ae3ce1b3291dbba8e2fb358d52bd77d",
+            wasmFilename: "circuit_small.wasm",
+            wasmStoragePath: "circuits/circuit_small/circuit_small.wasm"
         },
         avgTimings: {
             contributionComputation: 0,

diff --git a/packages/actions/test/unit/security.test.ts b/packages/actions/test/unit/security.test.ts
@@ -133,7 +133,11 @@ describe("Security", () => {
                     r1csBlake2bHash:
                         "0739198d5578a4bdaeb2fa2a1043a1d9cac988472f97337a0a60c296052b82d6cecb6ae7ce503ab9864bc86a38cdb583f2d33877c41543cbf19049510bca7472",
                     r1csFilename: "circuit_small.r1cs",
-                    r1csStoragePath: "circuits/circuit_small/circuit_small.r1cs"
+                    r1csStoragePath: "circuits/circuit_small/circuit_small.r1cs",
+                    wasmBlake2bHash:
+                        "00d09469acaba682802bf92df24708cf3d499b759379f959c4b6932b14fe9e6bfccc793c3933eac4a76546171d402cab1ae3ce1b3291dbba8e2fb358d52bd77d",
+                    wasmFilename: "circuit_small.wasm",
+                    wasmStoragePath: "circuits/circuit_small/circuit_small.wasm"
                 },
                 avgTimings: {
                     contributionComputation: 0,

diff --git a/packages/actions/test/unit/verification.test.ts b/packages/actions/test/unit/verification.test.ts
@@ -401,7 +401,11 @@ describe("Verification utilities", () => {
                         r1csBlake2bHash:
                             "0739198d5578a4bdaeb2fa2a1043a1d9cac988472f97337a0a60c296052b82d6cecb6ae7ce503ab9864bc86a38cdb583f2d33877c41543cbf19049510bca7472",
                         r1csFilename: "circuit.r1cs",
-                        r1csStoragePath: "circuits/circuit/circuit.r1cs"
+                        r1csStoragePath: "circuits/circuit/circuit.r1cs",
+                        wasmBlake2bHash:
+                            "00d09469acaba682802bf92df24708cf3d499b759379f959c4b6932b14fe9e6bfccc793c3933eac4a76546171d402cab1ae3ce1b3291dbba8e2fb358d52bd77d",
+                        wasmFilename: "circuit.wasm",
+                        wasmStoragePath: "circuits/circuit/circuit.wasm"
                     },
                     avgTimings: {
                         contributionComputation: 0,