Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add creating of cache directory if not exists #1302

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Add creating of cache directory if not exists #1302

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eebe225
Add creating of cache directory if not exists
alexander-schranz Nov 28, 2023
e252109
Make cache file handling more readable
alexander-schranz Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions src/Supportive/DependencyInjection/ServiceContainerBuilder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,11 +129,21 @@ private static function loadServices(ContainerBuilder $container, ?SplFileInfo $
return;
}

if (!file_exists($cacheFile->getPathname())
&& !touch($cacheFile->getPathname())
&& !is_writable($cacheFile->getPathname())
) {
throw CacheFileException::notWritable($cacheFile);
if (!file_exists($cacheFile->getPathname())) {
$dirname = $cacheFile->getPath() ?: '.';

if (!is_dir($dirname)
&& mkdir($dirname.'/', 0777, true)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The added backslash is neseccary? It just a copy from the baseline class, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah just copied from the baseline not sure why there was a backslash added.

&& !is_dir($dirname)
) {
throw CacheFileException::notWritable($cacheFile);
}

if (!touch($cacheFile->getPathname())
&& !is_writable($cacheFile->getPathname())
) {
throw CacheFileException::notWritable($cacheFile);
}
}

$container->setParameter('deptrac.cache_file', $cacheFile->getPathname());
Expand Down
Loading