explizit arguments get #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gennadigennadigennadi
force-pushed
the
issue-1425
branch
2 times, most recently
from
9055be9 to
2788afe
Compare
|
What was the reason to merge 703b212 in the past? I cannot find the related pull request. |
gennadigennadigennadi
force-pushed
the
issue-1425
branch
from
2788afe to
13b3e19
Compare
|
@xabbuh qossmic/deptrac#1089 that's the pr and @dbrumann had his doubts :-) |
|
Can we somehow add a test to prevent regressions? |
|
Hey there. Long time, no see. I just saw the ping a few days ago and had a quick look again. It definitely makes sense to revisit this. It would make the bootstrapping a lot easier and I am not sure in what cases I stumbled into the bug I was describing in the other PR. Maybe it was specific to an older version of Symfony, the way phar handled things or just me messing up during debugging. Tests would be nice to have though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: qossmic/deptrac#1425
If a not defined argument|option appears during application bootstrap,
getOption()returns nothing, because the previous bind couldn't parse the defined arguments|options.