use ALLOWED_CLASSES as Versioning hash

qossmic · Jun 17, 2024 · 961ef60 · 961ef60
1 parent 72caeb5
commit 961ef60
Showing 1 changed file with 27 additions and 21 deletions.
diff --git a/src/Core/Ast/Parser/Cache/AstFileReferenceFileCache.php b/src/Core/Ast/Parser/Cache/AstFileReferenceFileCache.php
@@ -43,7 +43,24 @@ class AstFileReferenceFileCache implements AstFileReferenceDeferredCacheInterfac
     /** @var array<string, bool> */
     private array $parsedFiles = [];
 
-    public function __construct(private readonly string $cacheFile, private readonly string $cacheVersion) {}
+    private const ALLOWED_CLASSES = [
+        FileReference::class,
+        ClassLikeReference::class,
+        FunctionReference::class,
+        VariableReference::class,
+        AstInherit::class,
+        DependencyToken::class,
+        DependencyType::class,
+        FileToken::class,
+        ClassLikeToken::class,
+        ClassLikeType::class,
+        FunctionToken::class,
+        SuperGlobalToken::class,
+        FileOccurrence::class,
+        DependencyContext::class,
+    ];
+
+    public function __construct(private readonly string $cacheFile) {}
 
     public function get(string $filepath): ?FileReference
     {
@@ -98,7 +115,7 @@ public function load(): void
 
         $this->loaded = true;
 
-        if (null === $cache || $this->cacheVersion !== $cache['version']) {
+        if (null === $cache || $this->generateVersionHash() !== $cache['version']) {
             return;
         }
 
@@ -107,25 +124,9 @@ public function load(): void
             static function (array $data): array {
                 $reference = unserialize(
                     $data['reference'],
-                    [
-                        'allowed_classes' => [
-                            FileReference::class,
-                            ClassLikeReference::class,
-                            FunctionReference::class,
-                            VariableReference::class,
-                            AstInherit::class,
-                            DependencyToken::class,
-                            DependencyType::class,
-                            FileToken::class,
-                            ClassLikeToken::class,
-                            ClassLikeType::class,
-                            FunctionToken::class,
-                            SuperGlobalToken::class,
-                            FileOccurrence::class,
-                            DependencyContext::class,
-                        ],
-                    ]
+                    ['allowed_classes' => self::ALLOWED_CLASSES]
                 );
+
                 assert($reference instanceof FileReference);
 
                 return [
@@ -162,13 +163,18 @@ static function (array $data): array {
             $this->cacheFile,
             json_encode(
                 [
-                    'version' => $this->cacheVersion,
+                    'version' => $this->generateVersionHash(),
                     'payload' => $payload,
                 ]
             )
         );
     }
 
+    private function generateVersionHash(): string
+    {
+        return hash('sha1', implode(', ', self::ALLOWED_CLASSES));
+    }
+
     /**
      * @throws FileNotExistsException
      */