Add threadId to PatternLayout #711
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roberto Cella <[email protected]>
Signed-off-by: Roberto Cella <[email protected]>
rob93c
force-pushed
the
add-threadId-converter
branch
from
0ceb4a7
to
65df97f
Compare
|
Hi @ceki, can you please confirm if the failing Github action is doing so because of an unrelated issue? |
griffinjm
reviewed
Mar 31, 2024
| public class ThreadIdConverter extends ClassicConverter { | ||
|
|
||
| public String convert(ILoggingEvent event) { | ||
| return String.valueOf(Thread.currentThread().getId()); |
There was a problem hiding this comment.
Should this be present in the ILoggingEvent and retrieved from there? Otherwise this can return the thread id of an internal logback thread, not the id of the actual caller thread, e.g. in an AsyncAppender. See prepareForDeferredProcessing() in the default impl class LoggingEvent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #710, let me know if there should be any other change I need to take care of.