LOGBACK-1729: Add OSGi Service Loader Mediator entries to load logback Configurators #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HannesWell
force-pushed
the
osgiConfiguratorLoader
branch
from
030623e to
7988a8e
Compare
HannesWell
changed the title
HannesWell
changed the title
|
@ceki would that also be interesting for the logback 1.3 branch? In general the same issue exists there are well. |
Add and improve the OSGi Service Loader Mediator entries to load logback Configurators provided by other bundles. Additionally add entry to provide the ServletContainerInitializer service implementation in OSGi runtimes via SPI. In general improve the overall quality of the Service Loader Mediator entries. See - https://docs.osgi.org/specification/osgi.cmpn/8.0.0/service.loader.html - https://aries.apache.org/documentation/modules/spi-fly.html#specconf Fixes https://jira.qos.ch/browse/LOGBACK-1729 Signed-off-by: Hannes Wellmann <[email protected]>
HannesWell
force-pushed
the
osgiConfiguratorLoader
branch
from
7988a8e to
2d4050e
Compare
|
Thank you for the quick review and merge. Should i create a back port to 1.3 for this PR too? |
|
Yes, please. |
|
Done in #643. |
This was referenced Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment logback cannot load Configurator implementations provided by other bundles in an OSGi runtime, because of missing Service Loader Mediator entries. This PR adds them, so the Service Loader Mediator implementation does not have to be configured to workaround the missing metadata.
Additionally add entry to provide the
ServletContainerInitializerservice implementation in OSGi runtimes via SPI.In general improve the overall quality of the Service Loader Mediator entries.
See
Fixes https://jira.qos.ch/browse/LOGBACK-1729.