Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dgrijalva/jwt-go v3.2.0 to golang-jwt/jwt v4.3.0 #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Clasyc
Copy link

@Clasyc Clasyc commented Mar 10, 2022

dgrijalva/jwt-go v3.2.0 has a security issue CVE-2020-26160, a security patch does not exist and it is recommended to switch to golang-jwt.

jwt-go before 4.0.0-preview1 allows attackers to bypass intended access restrictions in situations with []string{} for m["aud"] (which is allowed by the specification). Because the type assertion fails, "" is the value of aud. This is a security problem if the JWT token is presented to a service that lacks its own audience check.

https://github.com/golang-jwt/jwt/blob/main/MIGRATION_GUIDE.md

dgrijalva/jwt-go v3.2.0 has a security issue CVE-2020-26160, a security patch does not exist and it is recommended to switch to golang-jwt. https://github.com/golang-jwt/jwt/blob/main/MIGRATION_GUIDE.md
@Clasyc
Copy link
Author

Clasyc commented May 20, 2022

@raven-chen please, can you take a look on this?

@theplant-ci
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants