230 optional iouring #252

idruzhitskiy · 2023-03-13T16:34:21Z

Closes #230

idruzhitskiy · 2023-03-15T08:25:42Z

Closes #230

src/blob/index/benchmarks.rs

src/blob/index/bptree/tests.rs

src/blob/mod.rs

src/blob/index/benchmarks.rs

src/blob/index/bptree/tests.rs

src/io/mod.rs

src/storage/builder.rs

tests/tests.rs

ikopylov · 2023-03-17T21:25:05Z

tests/tests.rs

@@ -246,7 +247,17 @@ async fn test_work_dir_lock() {

            let storage = res_one.unwrap();
            let result = waitpid(child, None);
+            #[cfg(not(target_os = "macos"))]
            assert_eq!(Ok(WaitStatus::Exited(child, 0)), result);


This test is incorrect. fork splits test engine as well, so the forked process can continue running other tests. Probably, that is the reason why the exit code is 0 (on panic it should not be 0)

Please, update to use rusty-fork crate (https://docs.rs/rusty-fork/0.3.0/rusty_fork/fn.fork.html)

Actually, lets do this in a separate request. I added a new issue: #254 and assigned it to you

src/io/unix/sync.rs

Co-authored-by: ikopylov <[email protected]>

src/storage/builder.rs

src/io/unix/iouring.rs

Co-authored-by: ikopylov <[email protected]>

src/io/unix/iouring.rs

ikopylov

LGTM

Ivan Druzhitskiy added 4 commits March 13, 2023 18:16

add feature async-io-rio

4deca4e

remove rio dependency

fc5bd06

fix tests

cf615b7

update changelog

1d55e58

idruzhitskiy mentioned this pull request Mar 13, 2023

add non-linux support #251

Closed

Ivan Druzhitskiy added 9 commits March 13, 2023 19:40

disable rio for other features

e526afb

fix typo

735984c

fix typo

b327c85

make work dir test single threaded flavor

b4cd816

change dir structure

0400f15

make async io

ce52488

fix async io

12d811b

fix warning

4d442b1

fix lock

8c15b44

idruzhitskiy marked this pull request as ready for review March 15, 2023 08:25

idruzhitskiy requested a review from ikopylov March 15, 2023 08:25

Ivan Druzhitskiy added 6 commits March 15, 2023 11:28

fix default for async iodriver

e859222

make rio singleton

92be890

return tests to normal

0081539

remove old file

2ba3568

add asynciorio to build

7a1b5c9

rename linux -> unix

4db2518

ikopylov reviewed Mar 15, 2023

View reviewed changes

src/blob/index/benchmarks.rs Outdated Show resolved Hide resolved

ikopylov reviewed Mar 15, 2023

View reviewed changes

src/blob/index/benchmarks.rs Outdated Show resolved Hide resolved

ikopylov reviewed Mar 15, 2023

View reviewed changes

src/blob/index/benchmarks.rs Outdated Show resolved Hide resolved

ikopylov reviewed Mar 15, 2023

View reviewed changes

src/blob/index/benchmarks.rs Outdated Show resolved Hide resolved

ikopylov reviewed Mar 15, 2023

View reviewed changes

src/blob/index/benchmarks.rs Outdated Show resolved Hide resolved

ikopylov reviewed Mar 15, 2023

View reviewed changes

src/blob/index/bptree/tests.rs Outdated Show resolved Hide resolved

ikopylov reviewed Mar 15, 2023

View reviewed changes

src/blob/mod.rs Outdated Show resolved Hide resolved

Ivan Druzhitskiy added 5 commits March 16, 2023 17:30

style changes

e60d4bc

update tests

0599120

revert changes to cargo

b9650aa

fix error attr

2259f9f

fix test for macos

638e0b0