ArgoCD provider: remove ArgoCD/Kubernetes dependency #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcorbin
force-pushed
the
argocd-remove-k8s-deps
branch
from
4e23e0c to
ec7612a
Compare
The ArgoCD client dependencies are heavy and are a mess to upgrade. This commit use a simple HTTP client instead of the official ArgoCD client to fetch ArgoCD applications. All dependencies are also updated. Signed-off-by: Mathieu Corbin <[email protected]>
mcorbin
force-pushed
the
argocd-remove-k8s-deps
branch
from
ec7612a to
b8e3a31
Compare
|
#sre |
|
IIRC the default Argocd client is using GRPC api while here we switch to the rest API. Just to be sure we are aware and it's ok 🙂 |
yeah it's not an issue. I QA the change locally and everything worked as expected. |
boser87
pushed a commit
that referenced
this pull request
Aug 14, 2024
The ArgoCD client dependencies are heavy and are a mess to upgrade. This commit use a simple HTTP client instead of the official ArgoCD client to fetch ArgoCD applications. All dependencies are also updated. Signed-off-by: Mathieu Corbin <[email protected]> Signed-off-by: Stefano Celentano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ArgoCD client dependencies are heavy and are a mess to upgrade.
This commit use a simple HTTP client instead of the official ArgoCD client to fetch ArgoCD applications.
All dependencies are also updated.