refactor: use variable assignment and bound value instead of {{component}} helper #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vscav
force-pushed
the
move-off-component-helper
branch
from
6318cc7 to
fdbb5f4
Compare
vscav
changed the title
mrloop
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We move off the component helper to use a variable assignment and use the bound value in
element.hbs.Why?
Our goal is to migrate the addon to TypeScript. We'd like to use Glint. But the component helper will throw a linting error:
The {{component}} helper can't be used directly in block form under Glint. Consider first binding the result to a variable, e.g. '{{#let (component ...) as |...|}}' and then using the bound value.