Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from yarn to pnpm #24

Merged
merged 4 commits into from
Jun 1, 2023
Merged

Migrate from yarn to pnpm #24

merged 4 commits into from
Jun 1, 2023

Conversation

vscav
Copy link
Member

@vscav vscav commented Jun 1, 2023 •
edited
Loading

Description

pnpm is used instead of yarn to manage the project.

Changes

  • pnpm (v.8.6.0) is used instead of yarn
    • "workspaces" field is removed from package.json because it is not supported by pnpm - we use a pnpm-workspace.yaml file instead
    • Bumped checkout and setup-node actions to v3 in ci.yml GitHub action
  • Dev dependencies of addon and test-app are upgraded

Checklist

  • Update package.json scripts to use pnpm
  • Run build, lint and test scripts locally
  • Update CI jobs to use pnpm

@vscav vscav changed the title Pnpm migration Migrate from yarn to pnpm Jun 1, 2023
@vscav vscav self-assigned this Jun 1, 2023
@vscav vscav marked this pull request as ready for review June 1, 2023 07:54
@vscav vscav requested a review from anas7asia June 1, 2023 07:56
@vscav vscav merged commit fb6e45b into main Jun 1, 2023
@vscav vscav mentioned this pull request Jun 1, 2023
Merged
@vscav vscav added the internal label Jun 2, 2023
@michelegera michelegera deleted the pnpm-migration branch October 2, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anas7asia anas7asia anas7asia approved these changes

Assignees

@vscav vscav

Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vscav @anas7asia