Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition away from Conda #7

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Conversation

mrl280
Copy link
Collaborator

@mrl280 mrl280 commented Jul 19, 2024

Description:
We were originally using Conda for this example because it is the easiest way to install GDAL, which is required to read the spectrogram masks from the uncovered spectrogram sensing dataset from MathWorks.

These changes adapt this example to use the Spectrum Sensing dataset in the RIA HDF5 file format, so Conda is not longer required:

  • Replaced environment.yaml with requirements.txt
  • Updated the download script to download our self hosted version of the dataset in the RIA HDF5 file format, instead of downloading from the MathWorks mirror.
  • Updated the notebook to use the dataset in the RIA HDF5 file format.
  • Clarity has been enhanced in a few places throughout the notebook.
  • Updated README.md with updated set up instructions.
  • Added developer dependencies to requirements_dev.txt

Tips for the Reviewer:
Follow the updated instructions in README.md to download the dataset and launch the notebook. Read through the notebook, and be on the lookout for typos and unclear explanations.

I tested on Windows, so it might be prudent for the reviewer to test on Linux.

Hardware/Driver Requirements:
None.

@mrl280 mrl280 linked an issue Jul 19, 2024 that may be closed by this pull request
@mrl280 mrl280 requested a review from pasquale8120 July 19, 2024 20:58
Update getting started instructions to register the `venv` kernel.

Previously, the instructions referenced the `spectrogram-segmentation` kernel used in the Conda implementation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transition away from Conda
1 participant