Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add OnExitWith configuration method #76

Merged
merged 1 commit into from
May 17, 2024
Merged

feat: add OnExitWith configuration method #76

merged 1 commit into from
May 17, 2024

Conversation

Metamogul
Copy link

This PR closes #75. It adds an additional configuration method OnExitWith that allows setting a specific action for leaving a state with a specific trigger similar to OnEntryFrom.

Copy link
Owner

@qmuntal qmuntal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new function needs some testing. You can probably get some ideas from OnEntryFrom tests.

@Metamogul Metamogul changed the title feat: add OnExitFrom configuration method (closes #75) feat: add OnExitWith configuration method (closes #75) May 17, 2024
@Metamogul
Copy link
Author

Sure thing! Looks like I had overlooked some tests; I've matched the coverage so it is en par now with the existing tests for OnEntryFrom.

@Metamogul Metamogul requested a review from qmuntal May 17, 2024 15:07
@qmuntal qmuntal changed the title feat: add OnExitWith configuration method (closes #75) feat: add OnExitWith configuration method May 17, 2024
Copy link
Owner

@qmuntal qmuntal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@qmuntal qmuntal merged commit ad13c0f into qmuntal:master May 17, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow adding actions for leaving a state with a specific trigger
2 participants