[keymap] Removing #4072 workaround! #9995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fauxpark
approved these changes
Aug 12, 2020
zvecr
approved these changes
Aug 13, 2020
|
Thanks! |
noroadsleft
approved these changes
Aug 17, 2020
|
Thanks! |
nicocesar
pushed a commit
to nicocesar/qmk_firmware
that referenced
this pull request
Sep 6, 2020
* move media keys in to move layer; rearragne f keys; use send_string for rev5 compatability * remove send_string workaround for qmk#4072
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't yet established when this was fixed, but the workaround for #4072 no longer seems to be necessary! 🎉