Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BM60 RGB ISO Keyboard #9975

Merged
merged 12 commits into from
Aug 18, 2020
Merged

Add BM60 RGB ISO Keyboard #9975

merged 12 commits into from
Aug 18, 2020

Conversation

markva
Copy link
Contributor

@markva markva commented Aug 8, 2020

Description

Added new Keyboard BM60 RGB ISO.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team August 12, 2020 14:11
@markva markva requested review from fauxpark and removed request for a team August 13, 2020 10:49
@markva
Copy link
Contributor Author

markva commented Aug 13, 2020

Oops, sorry didn't want to remove qmk/collaborators.

@fauxpark fauxpark requested a review from a team August 13, 2020 12:59
@noroadsleft noroadsleft self-requested a review August 17, 2020 10:44
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub tip: You can apply multiple suggestions to a single commit by using the Files Changed tab.

Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@noroadsleft noroadsleft merged commit 3f5f603 into qmk:master Aug 18, 2020
@sambaum sambaum mentioned this pull request Aug 23, 2020
4 tasks
nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Sep 6, 2020
* Add BM60 RGB ISO Keyboard

* fixed link to picture

* Update keyboards/bm60rgb_iso/bm60rgb_iso.c

* Update keyboards/bm60rgb_iso/config.h

* Update keyboards/bm60rgb_iso/config.h

* Update keyboards/bm60rgb_iso/info.json

* Update keyboards/bm60rgb_iso/info.json

* Update keyboards/bm60rgb_iso/rules.mk

* Delete vscode file

* Update my new username

* Disable console and commands

* Apply suggestions from code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants