Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Quackfire controller #9958

Merged
merged 4 commits into from
Aug 8, 2020
Merged

Add Quackfire controller #9958

merged 4 commits into from
Aug 8, 2020

Conversation

evyd13
Copy link
Contributor

@evyd13 evyd13 commented Aug 7, 2020

Description

Adds the Quackfire controller, a replacement controller for the CM Quickfire Rapid.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

PS: great to see that PR checklist 👍

keyboards/maartenwut/quackfire/rules.mk Show resolved Hide resolved
keyboards/maartenwut/quackfire/rules.mk Outdated Show resolved Hide resolved
@fauxpark fauxpark added keyboard via Adds via keymap and/or updates keyboard for via support labels Aug 7, 2020
@fauxpark fauxpark requested a review from a team August 7, 2020 12:34
keyboards/maartenwut/quackfire/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/maartenwut/quackfire/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/maartenwut/quackfire/keymaps/via/keymap.c Outdated Show resolved Hide resolved
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@noroadsleft noroadsleft merged commit a536e1b into qmk:master Aug 8, 2020
@noroadsleft
Copy link
Member

Thanks!

@evyd13 evyd13 deleted the quackfire branch August 8, 2020 18:45
@evyd13 evyd13 mentioned this pull request Aug 10, 2020
6 tasks
fdawans pushed a commit to fdawans/qmk_firmware that referenced this pull request Aug 11, 2020
* Add Quackfire controller

* Comply with PR checklist

* Update VIA keymap

* Update keyboards/maartenwut/quackfire/readme.md
fdawans added a commit to fdawans/qmk_firmware that referenced this pull request Aug 11, 2020
nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Aug 12, 2020
* Add Quackfire controller

* Comply with PR checklist

* Update VIA keymap

* Update keyboards/maartenwut/quackfire/readme.md
fcoury pushed a commit to fcoury/qmk_firmware_archive that referenced this pull request Sep 20, 2020
* Add Quackfire controller

* Comply with PR checklist

* Update VIA keymap

* Update keyboards/maartenwut/quackfire/readme.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants