Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kabedon keyboards #9929

Merged
merged 28 commits into from
Aug 7, 2020
Merged

Add kabedon keyboards #9929

merged 28 commits into from
Aug 7, 2020

Conversation

370490639
Copy link
Contributor

@370490639 370490639 commented Aug 3, 2020 •
edited
Loading

Description

Add kabedon keyboards

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@370490639 370490639 mentioned this pull request Aug 4, 2020
Merged
6 tasks
fauxpark
fauxpark requested changes Aug 6, 2020
View reviewed changes
keyboards/kabedon/kabedon78s/README.md Outdated Show resolved Hide resolved
keyboards/kabedon/kabedon78s/config.h Outdated Show resolved Hide resolved
keyboards/kabedon/kabedon78s/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/kabedon/kabedon78s/rules.mk Outdated Show resolved Hide resolved
keyboards/kabedon/kabedon78s/rules.mk Outdated Show resolved Hide resolved
keyboards/kabedon/kabedon980/kabedon980.c Outdated Show resolved Hide resolved
keyboards/kabedon/kabedon980/kabedon980.c Outdated Show resolved Hide resolved
keyboards/kabedon/kabedon980/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/kabedon/kabedon980/rules.mk Outdated Show resolved Hide resolved
keyboards/kabedon/kabedon980/rules.mk Outdated Show resolved Hide resolved
@fauxpark fauxpark added keyboard via Adds via keymap and/or updates keyboard for via support labels Aug 6, 2020
@fauxpark fauxpark requested a review from a team August 6, 2020 19:10
noroadsleft
noroadsleft requested changes Aug 7, 2020
View reviewed changes
keyboards/kabedon/kabedon980/info.json Outdated Show resolved Hide resolved
keyboards/kabedon/kabedon980/info.json Outdated Show resolved Hide resolved
fauxpark
fauxpark requested changes Aug 7, 2020
View reviewed changes
keyboards/kabedon/kabedon78s/rules.mk Outdated Show resolved Hide resolved
keyboards/kabedon/kabedon980/README.md Outdated Show resolved Hide resolved
keyboards/kabedon/kabedon78s/README.md Outdated Show resolved Hide resolved
keyboards/kabedon/kabedon980/rules.mk Outdated Show resolved Hide resolved
keyboards/kabedon/kabedon980/rules.mk Show resolved Hide resolved
fauxpark
fauxpark requested changes Aug 7, 2020
View reviewed changes
keyboards/kabedon/kabedon980/README.md Outdated Show resolved Hide resolved
keyboards/kabedon/kabedon78s/README.md Outdated Show resolved Hide resolved
@fauxpark fauxpark requested a review from a team August 7, 2020 10:17
@370490639 370490639 requested review from noroadsleft and removed request for a team August 7, 2020 11:13
@noroadsleft noroadsleft merged commit a260cbb into qmk:master Aug 7, 2020
@noroadsleft
Copy link
Member

Thanks!

fdawans pushed a commit to fdawans/qmk_firmware that referenced this pull request Aug 11, 2020
@370490639 @fdawans
[Keyboard] Add kabedon keyboards (qmk#9929)
8a98a3e 
* Add kabedon keyboards

* #define DYNAMIC_KEYMAP_EEPROM_MAX_ADDR 2047

* change README.md

* Update README.md

* Update config.h

* Update keymap.c

* Update rules.mk

* Update rules.mk

* Update README.md

* Update info.json

* Update kabedon980.c

* Update keymap.c

* Update rules.mk

* Update config.h

* Update config.h

* Update info.json

* Update README.md

* Update rules.mk

* Update README.md

* Update kabedon980.c

* Update rules.mk

* Update rules.mk

* Update rules.mk

* Update rules.mk

* Update rules.mk

* Update README.md

* Update README.md

* Update info.json
fdawans added a commit to fdawans/qmk_firmware that referenced this pull request Aug 11, 2020
@fdawans
Revert "[Keyboard] Add kabedon keyboards (qmk#9929)"
e7c317b 
This reverts commit 8a98a3e.
nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Aug 12, 2020
@370490639 @nicocesar
[Keyboard] Add kabedon keyboards (qmk#9929)
a6ca3c4 
* Add kabedon keyboards

* #define DYNAMIC_KEYMAP_EEPROM_MAX_ADDR 2047

* change README.md

* Update README.md

* Update config.h

* Update keymap.c

* Update rules.mk

* Update rules.mk

* Update README.md

* Update info.json

* Update kabedon980.c

* Update keymap.c

* Update rules.mk

* Update config.h

* Update config.h

* Update info.json

* Update README.md

* Update rules.mk

* Update README.md

* Update kabedon980.c

* Update rules.mk

* Update rules.mk

* Update rules.mk

* Update rules.mk

* Update rules.mk

* Update README.md

* Update README.md

* Update info.json
fcoury pushed a commit to fcoury/qmk_firmware_archive that referenced this pull request Sep 20, 2020
@370490639 @fcoury
[Keyboard] Add kabedon keyboards (qmk#9929)
98baf4d 
* Add kabedon keyboards

* #define DYNAMIC_KEYMAP_EEPROM_MAX_ADDR 2047

* change README.md

* Update README.md

* Update config.h

* Update keymap.c

* Update rules.mk

* Update rules.mk

* Update README.md

* Update info.json

* Update kabedon980.c

* Update keymap.c

* Update rules.mk

* Update config.h

* Update config.h

* Update info.json

* Update README.md

* Update rules.mk

* Update README.md

* Update kabedon980.c

* Update rules.mk

* Update rules.mk

* Update rules.mk

* Update rules.mk

* Update rules.mk

* Update README.md

* Update README.md

* Update info.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@370490639 @noroadsleft @fauxpark