Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add mini_bom chorded keymap #9916

Merged
merged 7 commits into from
Aug 7, 2020
Merged

add mini_bom chorded keymap #9916

merged 7 commits into from
Aug 7, 2020

Conversation

keyboard-magpie
Copy link
Contributor

@keyboard-magpie keyboard-magpie commented Aug 2, 2020 •
edited
Loading

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • add a keymap with chording, inspired by gboards gergoplex default, to the centromere mini keyboard.

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

drashna
drashna requested changes Aug 7, 2020
View reviewed changes
keyboards/centromere/keymaps/mini_bom/config.h Outdated Show resolved Hide resolved
keyboards/centromere/keymaps/mini_bom/keymap.c Show resolved Hide resolved
keyboards/centromere/keymaps/mini_bom/rules.mk Outdated Show resolved Hide resolved
keyboards/centromere/keymaps/mini_bom/keymap.c Outdated Show resolved Hide resolved
@drashna drashna added the keymap label Aug 7, 2020
@drashna drashna requested a review from a team August 7, 2020 06:59
@keyboard-magpie
Copy link
Contributor Author

Thanks @drashna for the tidy up

noroadsleft
noroadsleft approved these changes Aug 7, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@noroadsleft noroadsleft merged commit 24c8982 into qmk:master Aug 7, 2020
@noroadsleft
Copy link
Member

Thanks!

fdawans pushed a commit to fdawans/qmk_firmware that referenced this pull request Aug 11, 2020
@keyboard-magpie @fdawans
[Keymap] add mini_bom chorded keymap (qmk#9916)
13990c4 
* add mini_bom chorded keymap

* Update keymap.c

* Update config.h

* Update keyboards/centromere/keymaps/mini_bom/config.h

* Update keyboards/centromere/keymaps/mini_bom/keymap.c

* Update keyboards/centromere/keymaps/mini_bom/rules.mk

* Update keyboards/centromere/keymaps/mini_bom/keymap.c
fdawans added a commit to fdawans/qmk_firmware that referenced this pull request Aug 11, 2020
@fdawans
Revert "[Keymap] add mini_bom chorded keymap (qmk#9916)"
ac2a2fe 
This reverts commit 13990c4.
nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Aug 12, 2020
@keyboard-magpie @nicocesar
[Keymap] add mini_bom chorded keymap (qmk#9916)
6e480f3 
* add mini_bom chorded keymap

* Update keymap.c

* Update config.h

* Update keyboards/centromere/keymaps/mini_bom/config.h

* Update keyboards/centromere/keymaps/mini_bom/keymap.c

* Update keyboards/centromere/keymaps/mini_bom/rules.mk

* Update keyboards/centromere/keymaps/mini_bom/keymap.c
fcoury pushed a commit to fcoury/qmk_firmware_archive that referenced this pull request Sep 20, 2020
@keyboard-magpie @fcoury
[Keymap] add mini_bom chorded keymap (qmk#9916)
74d06cc 
* add mini_bom chorded keymap

* Update keymap.c

* Update config.h

* Update keyboards/centromere/keymaps/mini_bom/config.h

* Update keyboards/centromere/keymaps/mini_bom/keymap.c

* Update keyboards/centromere/keymaps/mini_bom/rules.mk

* Update keyboards/centromere/keymaps/mini_bom/keymap.c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna requested changes

@noroadsleft noroadsleft noroadsleft approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@keyboard-magpie @noroadsleft @drashna @fauxpark