Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ANSI with Arrow Layout & RGB Underglow as a Caps Lock Indicator #9910

Merged
merged 5 commits into from
Aug 5, 2020
Merged

Add ANSI with Arrow Layout & RGB Underglow as a Caps Lock Indicator #9910

merged 5 commits into from
Aug 5, 2020

Conversation

mrsendyyk
Copy link
Contributor

@mrsendyyk mrsendyyk commented Aug 1, 2020

Description

  1. Add ANSI layout with arrow
  2. Add RGB Underglow as a caps lock indicator

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • None

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@mrsendyyk mrsendyyk changed the title KBDfans DZ60 ANSI with Arrow also RGB Underglow as a Caps Lock Indicator Add ANSI with Arrow Layout & RGB Underglow as a Caps Lock Indicator Aug 3, 2020
@fauxpark fauxpark requested a review from a team August 4, 2020 00:31
@fauxpark fauxpark added the keymap label Aug 4, 2020
@mrsendyyk mrsendyyk requested review from fauxpark and removed request for a team August 4, 2020 08:02
@mrsendyyk
Copy link
Contributor Author

Whoa sorry, i'm accidentally removed request for qmk/collaborators.

Update build environment setup link, make instructions link, and make instructions link.
@mrsendyyk
Copy link
Contributor Author

Hi @fauxpark, can you requested a review from qmk/collaborators again? I'm accidentally removed request for qmk/collaborators.
Thank you

@fauxpark fauxpark requested a review from a team August 4, 2020 12:36
@noroadsleft noroadsleft merged commit 37cbf7b into qmk:master Aug 5, 2020
@noroadsleft
Copy link
Member

Thanks!

@mrsendyyk
Copy link
Contributor Author

Thanks!

Thank you @fauxpark & @noroadsleft

fdawans pushed a commit to fdawans/qmk_firmware that referenced this pull request Aug 11, 2020
…dicator (qmk#9910)

* KBDfans DZ60 ANSI with Arrow also RGB Underglow as a Caps Lock Indicator

* Change all the KC_NOs to _______ (seven underscores)

* change all the KC_NOs to _______ (seven underscores)

* Update keymap.c

* Update readme.md

Update build environment setup link, make instructions link, and make instructions link.
fdawans added a commit to fdawans/qmk_firmware that referenced this pull request Aug 11, 2020
nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Aug 12, 2020
…dicator (qmk#9910)

* KBDfans DZ60 ANSI with Arrow also RGB Underglow as a Caps Lock Indicator

* Change all the KC_NOs to _______ (seven underscores)

* change all the KC_NOs to _______ (seven underscores)

* Update keymap.c

* Update readme.md

Update build environment setup link, make instructions link, and make instructions link.
fcoury pushed a commit to fcoury/qmk_firmware_archive that referenced this pull request Sep 20, 2020
…dicator (qmk#9910)

* KBDfans DZ60 ANSI with Arrow also RGB Underglow as a Caps Lock Indicator

* Change all the KC_NOs to _______ (seven underscores)

* change all the KC_NOs to _______ (seven underscores)

* Update keymap.c

* Update readme.md

Update build environment setup link, make instructions link, and make instructions link.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants