Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keymap for squiggle goldberg. #9909

Merged
merged 2 commits into from
Aug 7, 2020
Merged

keymap for squiggle goldberg. #9909

merged 2 commits into from
Aug 7, 2020

Conversation

ibnuda
Copy link
Contributor

@ibnuda ibnuda commented Aug 1, 2020

Added a keymap example for squiggle, goldberg version.

Description

currently, there is no example for LAYOUT_complicated for squiggle keyboard. this PR fixes that.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team August 7, 2020 06:42
@drashna drashna added the keymap label Aug 7, 2020
@fauxpark
Copy link
Member

fauxpark commented Aug 7, 2020

Thanks!

@fauxpark fauxpark merged commit 242336d into qmk:master Aug 7, 2020
@ibnuda ibnuda deleted the goldberg-keymap branch August 7, 2020 09:43
fdawans pushed a commit to fdawans/qmk_firmware that referenced this pull request Aug 11, 2020
@ibnuda @fdawans
keymap for squiggle goldberg. (qmk#9909)
336d91b
fdawans added a commit to fdawans/qmk_firmware that referenced this pull request Aug 11, 2020
@fdawans
Revert "keymap for squiggle goldberg. (qmk#9909)"
7b4312e 
This reverts commit 336d91b.
nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Aug 12, 2020
@ibnuda @nicocesar
keymap for squiggle goldberg. (qmk#9909)
1a5894d
fcoury pushed a commit to fcoury/qmk_firmware_archive that referenced this pull request Sep 20, 2020
@ibnuda @fcoury
keymap for squiggle goldberg. (qmk#9909)
1e31368
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ibnuda @fauxpark @drashna