-
-
Notifications
You must be signed in to change notification settings - Fork 39.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix configuration data for keyboard pom_keyboards/tnln95 #9904
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes to the file contents themselves look good, but technically speaking, the default
keymap should be named default_ansi
and the default_full
keymap should be named default
.
https://docs.qmk.fm/#/hardware_keyboard_guidelines?id=ltkeyboard_namehgt, Paragraph 3:
When defining multiple layouts you should have a base layout, named
LAYOUT_all
, that supports all possible switch positions on your matrix, even if that layout is impossible to build physically. This is the macro you should use in yourdefault
keymap. You should then have additional keymaps nameddefault_<layout>
that use your other layout macros. This will make it easier for people to use the layouts you define.
I feel like I should apologize for this trouble. I knew that the |
@noroadsleft I have renamed the keymap. |
Thanks! |
* fix configuration data, comment out unused layout * fix keymap * add info for layout all * change keymap name
* fix configuration data, comment out unused layout * fix keymap * add info for layout all * change keymap name
* fix configuration data, comment out unused layout * fix keymap * add info for layout all * change keymap name
I checked my keyboard layout on configurator and it doesn't work as intended.
Description
I update the info file.
I commented out layout "all" to avoid confusion in the configurator (it appears despite not declared in the info file).I add layout all to info file
I rearrange the layout "ansi".
Types of Changes
Issues Fixed or Closed by This PR
Checklist