Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Add Spider Island 78 key ps2avrGB based keyboard #9900

Merged
merged 1 commit into from
Sep 23, 2020
Merged

[Keyboard] Add Spider Island 78 key ps2avrGB based keyboard #9900

merged 1 commit into from
Sep 23, 2020

Conversation

valpackett
Copy link
Contributor

@valpackett valpackett commented Jul 31, 2020 •
edited
Loading

Support for this keyboard → https://a.aliexpress.com/_dVJsSpR

Split keyboard with "floating key" design, ps2avrGB stock firmware, non-RGB backlight, mini-USB connection, SATA cable for connecting the halves.

Matrix code copied from split75 (#8511). Would be nice to reuse it but I don't see any place for "common" matrix code.

TODO

  • JSON
  • better Fn keymap?

@valpackett valpackett marked this pull request as ready for review August 3, 2020 22:03
@valpackett valpackett changed the title [Keyboard] Add Spider Island 87 key ps2avrGB based keyboard [Keyboard] Add Spider Island 78 key ps2avrGB based keyboard Aug 6, 2020
fauxpark
fauxpark requested changes Aug 6, 2020
View reviewed changes
keyboards/spiderisland_split/rules.mk Outdated Show resolved Hide resolved
keyboards/spiderisland_split/rules.mk Outdated Show resolved Hide resolved
keyboards/spiderisland_split/keymaps/default/keymap.c Outdated Show resolved Hide resolved
fauxpark
fauxpark requested changes Aug 6, 2020
View reviewed changes
keyboards/spiderisland_split/info.json Outdated Show resolved Hide resolved
keyboards/spiderisland_split/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/spiderisland_split/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/spiderisland_split/spiderisland_split.h Outdated Show resolved Hide resolved
@fauxpark fauxpark requested a review from a team August 6, 2020 16:25
@valpackett valpackett force-pushed the spiderisland branch 2 times, most recently from f0d17b0 to 9358bc6 Compare August 6, 2020 20:29
noroadsleft
noroadsleft requested changes Aug 7, 2020
View reviewed changes
keyboards/spiderisland_split/config.h Outdated Show resolved Hide resolved
keyboards/spiderisland_split/readme.md Outdated Show resolved Hide resolved
@stale
Copy link

stale bot commented Sep 21, 2020

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

noroadsleft
noroadsleft requested changes Sep 22, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, It's a bit unusual, but I'm thinking I'd rather have the source folder be spiderisland/split78 instead of spiderisland_split. Who know what other boards might appear from this vendor.

keyboards/spiderisland_split/config.h Outdated Show resolved Hide resolved
keyboards/spiderisland_split/readme.md Outdated Show resolved Hide resolved
noroadsleft
noroadsleft approved these changes Sep 22, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@noroadsleft noroadsleft requested a review from a team September 22, 2020 20:27
@noroadsleft noroadsleft merged commit 8b9617f into qmk:master Sep 23, 2020
@noroadsleft
Copy link
Member

Thanks!

rgoulter pushed a commit to rgoulter/qmk_firmware that referenced this pull request Oct 4, 2020
@valpackett @rgoulter
[Keyboard] Add Spider Island split 78 key ps2avrGB based keyboard (qm…
24c77aa 
…k#9900)
kjganz pushed a commit to kjganz/qmk_firmware that referenced this pull request Oct 28, 2020
@valpackett
[Keyboard] Add Spider Island split 78 key ps2avrGB based keyboard (qm…
2012b9c 
…k#9900)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@valpackett @noroadsleft @fauxpark