Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[keymap] Update default layout for craftwalk #9888

Merged
merged 1 commit into from
Aug 6, 2020
Merged

[keymap] Update default layout for craftwalk #9888

merged 1 commit into from
Aug 6, 2020

Conversation

sotoba
Copy link
Contributor

@sotoba sotoba commented Jul 31, 2020

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

none.

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

drashna
drashna approved these changes Aug 5, 2020
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@drashna drashna requested a review from a team August 5, 2020 07:11
@noroadsleft noroadsleft merged commit 60d8d86 into qmk:master Aug 6, 2020
@noroadsleft
Copy link
Member

Thanks!

fdawans pushed a commit to fdawans/qmk_firmware that referenced this pull request Aug 11, 2020
@sotoba @fdawans
Update default layout for craftwalk (qmk#9888)
292edab 
* fix cratfwalk default layout
fdawans added a commit to fdawans/qmk_firmware that referenced this pull request Aug 11, 2020
@fdawans
Revert "Update default layout for craftwalk (qmk#9888)"
9a5daa2 
This reverts commit 292edab.
nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Aug 12, 2020
@sotoba @nicocesar
Update default layout for craftwalk (qmk#9888)
e1d7bb8 
* fix cratfwalk default layout
fcoury pushed a commit to fcoury/qmk_firmware_archive that referenced this pull request Sep 20, 2020
@sotoba @fcoury
Update default layout for craftwalk (qmk#9888)
8041168 
* fix cratfwalk default layout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sotoba @noroadsleft @drashna @fauxpark