Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Add kudox via compatibility #9875

Merged
merged 12 commits into from
Aug 6, 2020
Merged

[Keyboard] Add kudox via compatibility #9875

merged 12 commits into from
Aug 6, 2020

Conversation

x1-
Copy link
Contributor

@x1- x1- commented Jul 30, 2020 •
edited
Loading

Description

  • Add compatibility for VIA on kudox/rev3.
  • Add compatibility for VIA on kudox/columner.
  • Add compatibility for VIA on kudox-game.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • N/A

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Thank you for reviewing 🎉

zvecr
zvecr requested changes Jul 30, 2020
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keyboards/kudox/rev1/info.json should not be deleted.

@zvecr zvecr added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jul 30, 2020
@x1- x1- force-pushed the add-kudox-via-compatibility branch from f432bb4 to 2491f19 Compare July 30, 2020 15:31
@x1-
Copy link
Contributor Author

x1- commented Jul 31, 2020

@zvecr Thank you for reviewing! I reverted keyboards/kudox/rev1/info.json.

drashna
drashna requested changes Aug 5, 2020
View reviewed changes
keyboards/kudox/rev1/info.json Outdated Show resolved Hide resolved
keyboards/kudox/columner/info.json Outdated Show resolved Hide resolved
keyboards/kudox/rev3/info.json Outdated Show resolved Hide resolved
keyboards/kudox/rev3/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/kudox_game/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/kudox/columner/keymaps/via/keymap.c Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team August 5, 2020 04:14
@x1- x1- force-pushed the add-kudox-via-compatibility branch from ecb5e33 to 6deeac7 Compare August 5, 2020 05:56
@x1-
Copy link
Contributor Author

x1- commented Aug 5, 2020

@drashna Thank you for reviewing. I modified your suggested points.

noroadsleft
noroadsleft requested changes Aug 6, 2020
View reviewed changes
keyboards/kudox/rev1/info.json Outdated Show resolved Hide resolved
@x1-
Copy link
Contributor Author

x1- commented Aug 6, 2020

@noroadsleft Thank you for reviewing.
I reverted LAYOUT from LAYOUT_default on keyboards/kudox/rev1/info.json.
But PR Lint job on GitHub Actions failed. Is it ok...?

@noroadsleft
Copy link
Member

I reverted LAYOUT from LAYOUT_default on keyboards/kudox/rev1/info.json.
But PR Lint job on GitHub Actions failed. Is it ok...?

It's comparing current qmk:master with your source branch. The failures are on boards you haven't changed, so it's fine; it's marking issues on our end.

@noroadsleft noroadsleft merged commit db54a7b into qmk:master Aug 6, 2020
@noroadsleft
Copy link
Member

Thanks!

fdawans pushed a commit to fdawans/qmk_firmware that referenced this pull request Aug 11, 2020
@x1- @fdawans
[Keyboard] Add kudox via compatibility (qmk#9875)
f634894 
* Modify VENDOR_ID of kudox-keyboard series.

* Add via support for kudox/rev3.

* Add via support for kudox/columner.

* Add via support for kudox-game keyboard.

* Remove info.json from kudox/rev1.

* Revert kudox/rev1/info.json.

* Remove redundancy spaces.

* Add key_count on kudox/**/info.json.

* Remove unsupported items from info.json.

* Modify to use rgblight_mode from rgblight_mode_noeeprom

* Remove unneed line from info.json

* Revert keyboards/kudox/rev1/info.json
fdawans added a commit to fdawans/qmk_firmware that referenced this pull request Aug 11, 2020
@fdawans
Revert "[Keyboard] Add kudox via compatibility (qmk#9875)"
56d21d2 
This reverts commit f634894.
nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Aug 12, 2020
@x1- @nicocesar
[Keyboard] Add kudox via compatibility (qmk#9875)
85e34b3 
* Modify VENDOR_ID of kudox-keyboard series.

* Add via support for kudox/rev3.

* Add via support for kudox/columner.

* Add via support for kudox-game keyboard.

* Remove info.json from kudox/rev1.

* Revert kudox/rev1/info.json.

* Remove redundancy spaces.

* Add key_count on kudox/**/info.json.

* Remove unsupported items from info.json.

* Modify to use rgblight_mode from rgblight_mode_noeeprom

* Remove unneed line from info.json

* Revert keyboards/kudox/rev1/info.json
fcoury pushed a commit to fcoury/qmk_firmware_archive that referenced this pull request Sep 20, 2020
@x1- @fcoury
[Keyboard] Add kudox via compatibility (qmk#9875)
3ea333e 
* Modify VENDOR_ID of kudox-keyboard series.

* Add via support for kudox/rev3.

* Add via support for kudox/columner.

* Add via support for kudox-game keyboard.

* Remove info.json from kudox/rev1.

* Revert kudox/rev1/info.json.

* Remove redundancy spaces.

* Add key_count on kudox/**/info.json.

* Remove unsupported items from info.json.

* Modify to use rgblight_mode from rgblight_mode_noeeprom

* Remove unneed line from info.json

* Revert keyboards/kudox/rev1/info.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna requested changes

@zvecr zvecr zvecr requested changes

@noroadsleft noroadsleft noroadsleft approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@x1- @noroadsleft @drashna @fauxpark @zvecr