Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keyboard] Added a new handwired 2x3,2x4,2x5 keyboard called the Stream_cheap #9871

Merged
merged 28 commits into from
Jul 31, 2020

Conversation

hartk1213
Copy link
Contributor

@hartk1213 hartk1213 commented Jul 29, 2020

stream cheap is a diy version of the El Gato Stream deck minus the LCD keys
but you can always get relegendable keycaps to change the icon if you want

Description

stream cheap is a diy version of the El Gato Stream deck minus the LCD keys
but you can always get relegendable keycaps to change the icon if you want

Types of Changes

added new files didnt change any old stuff, my new keyboard can be a 2x3, 2x4, or a 2x5 macro pad the case is 3d printed and is available here

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

stream cheap is a diy version of the El Gato Stream deck minus the LCD keys
but you can always get relegendable keycaps to change the icon if you want
@hartk1213 hartk1213 changed the title Added a new handwired 2x3,2x4,2x5 keyboard called the Stream_cheap [Keyboard] Added a new handwired 2x3,2x4,2x5 keyboard called the Stream_cheap Jul 30, 2020
was trying to add macros and multi key commands to the keymap,

i added 2 ctrl commands that have more than one key i.e. ctrl-k-c (visual studio comment hot key)

and i added a test string to see how type out a string with the press of a button
keyboards/handwired/stream_cheap/2x3/2x3.c Outdated Show resolved Hide resolved
keyboards/handwired/stream_cheap/2x3/config.h Outdated Show resolved Hide resolved
keyboards/handwired/stream_cheap/2x3/rules.mk Outdated Show resolved Hide resolved
keyboards/handwired/stream_cheap/2x4/2x4.c Outdated Show resolved Hide resolved
keyboards/handwired/stream_cheap/2x4/config.h Outdated Show resolved Hide resolved
keyboards/handwired/stream_cheap/2x5/2x5.c Outdated Show resolved Hide resolved
keyboards/handwired/stream_cheap/2x5/config.h Outdated Show resolved Hide resolved
keyboards/handwired/stream_cheap/2x5/rules.mk Outdated Show resolved Hide resolved
keyboards/handwired/stream_cheap/2x5/info.json Outdated Show resolved Hide resolved
keyboards/handwired/stream_cheap/config.h Outdated Show resolved Hide resolved
@zvecr zvecr added the keyboard label Jul 30, 2020
@zvecr zvecr requested a review from a team July 30, 2020 12:56
keyboards/handwired/stream_cheap/2x3/config.h Outdated Show resolved Hide resolved
keyboards/handwired/stream_cheap/2x3/info.json Outdated Show resolved Hide resolved
keyboards/handwired/stream_cheap/2x4/config.h Outdated Show resolved Hide resolved
keyboards/handwired/stream_cheap/2x4/info.json Outdated Show resolved Hide resolved
keyboards/handwired/stream_cheap/2x5/config.h Outdated Show resolved Hide resolved
keyboards/handwired/stream_cheap/2x5/info.json Outdated Show resolved Hide resolved
hartk1213 and others added 21 commits July 30, 2020 09:11
@hartk1213 hartk1213 requested review from fauxpark and zvecr July 30, 2020 16:23
@hartk1213 hartk1213 requested a review from fauxpark July 31, 2020 04:07
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly changes to the layout macro names and code formatting (white space, indents), and some USB identity changes in case one were to purchase multiple Stream Cheaps in different sizes.

GitHub tip: use the Files Changed tab to apply multiple suggestions to a single commit.

keyboards/handwired/stream_cheap/2x3/2x3.h Outdated Show resolved Hide resolved
keyboards/handwired/stream_cheap/2x3/config.h Outdated Show resolved Hide resolved
keyboards/handwired/stream_cheap/2x3/info.json Outdated Show resolved Hide resolved
keyboards/handwired/stream_cheap/2x4/2x4.h Outdated Show resolved Hide resolved
keyboards/handwired/stream_cheap/2x5/config.h Outdated Show resolved Hide resolved
keyboards/handwired/stream_cheap/2x5/info.json Outdated Show resolved Hide resolved
keyboards/handwired/stream_cheap/readme.md Outdated Show resolved Hide resolved
keyboards/handwired/stream_cheap/readme.md Outdated Show resolved Hide resolved
changes suggested in code review

Co-authored-by: James Young <[email protected]>
@hartk1213 hartk1213 requested a review from noroadsleft July 31, 2020 21:31
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@noroadsleft noroadsleft merged commit f3b518a into qmk:master Jul 31, 2020
@noroadsleft
Copy link
Member

Thanks!

nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Aug 12, 2020
…am_cheap (qmk#9871)

* Added a new handwired 2x3,2x4,2x5 keyboard called the Stream_cheap

stream cheap is a diy version of the El Gato Stream deck minus the LCD keys
but you can always get relegendable keycaps to change the icon if you want

* added missing commas in info.json files

* update config to change pin definition

* changed keymap.c for 2x4

was trying to add macros and multi key commands to the keymap,

i added 2 ctrl commands that have more than one key i.e. ctrl-k-c (visual studio comment hot key)

and i added a test string to see how type out a string with the press of a button

* testing more changes to the keymap to the 2x5

* Update keyboards/handwired/stream_cheap/2x3/2x3.c

* Update keyboards/handwired/stream_cheap/2x3/config.h

* Update keyboards/handwired/stream_cheap/2x3/rules.mk

* Update keyboards/handwired/stream_cheap/2x5/config.h

* Update keyboards/handwired/stream_cheap/2x5/info.json

* Update keyboards/handwired/stream_cheap/2x3/config.h

* Update keyboards/handwired/stream_cheap/2x3/info.json

* Update keyboards/handwired/stream_cheap/2x4/config.h

* Update keyboards/handwired/stream_cheap/2x4/info.json

* Update keyboards/handwired/stream_cheap/2x4/keymaps/default/keymap.c

* Update keyboards/handwired/stream_cheap/2x5/info.json

* Update keyboards/handwired/stream_cheap/2x5/config.h

* Update keyboards/handwired/stream_cheap/2x5/rules.mk

* Update keyboards/handwired/stream_cheap/2x4/2x4.c

* Update keyboards/handwired/stream_cheap/2x4/config.h

* Update keyboards/handwired/stream_cheap/2x4/info.json

* Update keyboards/handwired/stream_cheap/2x5/2x5.c

* Update keyboards/handwired/stream_cheap/2x4/rules.mk

* removed file as per request of user zvecr

* removed line in rules.mk for 2x5

* Update keyboards/handwired/stream_cheap/2x5/keymaps/default/keymap.c

* Apply suggestions from code review

changes suggested in code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants