Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-initial commit of ztboards #9869

Merged
merged 21 commits into from
Aug 7, 2020
Merged

Re-initial commit of ztboards #9869

merged 21 commits into from
Aug 7, 2020

Conversation

phlopsuh
Copy link
Contributor

@phlopsuh phlopsuh commented Jul 29, 2020

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@phlopsuh
Copy link
Contributor Author

phlopsuh commented Jul 29, 2020

Just ended up closing my mangled PR and re-opened a new one. I also added the info.json files for each board. Sorry for making this one a PITA. Thank you!

keyboards/ztboards/after/config.h Outdated Show resolved Hide resolved
keyboards/ztboards/after/rules.mk Outdated Show resolved Hide resolved
keyboards/ztboards/noon/config.h Outdated Show resolved Hide resolved
keyboards/ztboards/noon/rules.mk Outdated Show resolved Hide resolved
@zvecr zvecr added keyboard via Adds via keymap and/or updates keyboard for via support labels Jul 30, 2020
@zvecr zvecr requested a review from a team July 30, 2020 13:57
keyboards/ztboards/after/config.h Outdated Show resolved Hide resolved
keyboards/ztboards/after/config.h Outdated Show resolved Hide resolved
keyboards/ztboards/noon/config.h Outdated Show resolved Hide resolved
keyboards/ztboards/after/info.json Outdated Show resolved Hide resolved
keyboards/ztboards/noon/info.json Outdated Show resolved Hide resolved
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@noroadsleft noroadsleft merged commit c125d0a into qmk:master Aug 7, 2020
@noroadsleft
Copy link
Member

Thanks!

@phlopsuh
Copy link
Contributor Author

phlopsuh commented Aug 7, 2020

Thanks!

Thank you guys for all of your hard work and dealing with my QMK blunders.

fdawans pushed a commit to fdawans/qmk_firmware that referenced this pull request Aug 11, 2020
* Re-initial commit of ztboards

* Added info.json

* Made changes to info.json

* Update keyboards/ztboards/after/config.h

* Update keyboards/ztboards/after/rules.mk

* Update keyboards/ztboards/noon/rules.mk

* Update keyboards/ztboards/noon/config.h

* Update keyboards/ztboards/after/config.h

* Update keyboards/ztboards/noon/config.h

* Update keyboards/ztboards/after/config.h

* Update keyboards/ztboards/after/info.json

* Update keyboards/ztboards/noon/info.json

* Update noon.h

* Update keymap.c

* Update keymap.c

* Update keymap.c

* Update keymap.c

* Update noon.h

* Update keymap.c

* Update keymap.c

* Update noon.h
fdawans added a commit to fdawans/qmk_firmware that referenced this pull request Aug 11, 2020
nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Aug 12, 2020
* Re-initial commit of ztboards

* Added info.json

* Made changes to info.json

* Update keyboards/ztboards/after/config.h

* Update keyboards/ztboards/after/rules.mk

* Update keyboards/ztboards/noon/rules.mk

* Update keyboards/ztboards/noon/config.h

* Update keyboards/ztboards/after/config.h

* Update keyboards/ztboards/noon/config.h

* Update keyboards/ztboards/after/config.h

* Update keyboards/ztboards/after/info.json

* Update keyboards/ztboards/noon/info.json

* Update noon.h

* Update keymap.c

* Update keymap.c

* Update keymap.c

* Update keymap.c

* Update noon.h

* Update keymap.c

* Update keymap.c

* Update noon.h
fcoury pushed a commit to fcoury/qmk_firmware_archive that referenced this pull request Sep 20, 2020
* Re-initial commit of ztboards

* Added info.json

* Made changes to info.json

* Update keyboards/ztboards/after/config.h

* Update keyboards/ztboards/after/rules.mk

* Update keyboards/ztboards/noon/rules.mk

* Update keyboards/ztboards/noon/config.h

* Update keyboards/ztboards/after/config.h

* Update keyboards/ztboards/noon/config.h

* Update keyboards/ztboards/after/config.h

* Update keyboards/ztboards/after/info.json

* Update keyboards/ztboards/noon/info.json

* Update noon.h

* Update keymap.c

* Update keymap.c

* Update keymap.c

* Update keymap.c

* Update noon.h

* Update keymap.c

* Update keymap.c

* Update noon.h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants