add support for ModelM USB board #9846

mschwingen · 2020-07-27T18:42:31Z

Add new keyboard: IBM Model M replacement USB board:
https://github.com/mschwingen/hardware/tree/master/modelm-usb

Description

Add new keyboard: IBM Model M replacement USB board

Types of Changes

Issues Fixed or Closed by This PR

Checklist

[X ] My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
[ X] I have read the CONTRIBUTING document.
I have added tests to cover my changes.
[X ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

keyboards/mschwingen/modelm/keymaps/default/keymap.c

keyboards/mschwingen/modelm/led_ws2812/rules.mk

keyboards/mschwingen/modelm/rules.mk

keyboards/mschwingen/modelm/config.h

keyboards/mschwingen/modelm/keymaps/default/keymap.c

keyboards/mschwingen/modelm/rules.mk

Co-authored-by: James Young <[email protected]>

Co-authored-by: Drashna Jaelre <[email protected]>

…able to line up columns

keyboards/mschwingen/modelm/config.h

keyboards/mschwingen/modelm/rules.mk

keyboards/mschwingen/modelm/matrix.c

keyboards/mschwingen/modelm/README.md

Co-authored-by: Ryan <[email protected]>

use spi_read from core insteads of our own copy Co-authored-by: Ryan <[email protected]>

keyboards/mschwingen/modelm/keymaps/default/keymap.c

keyboards/mschwingen/modelm/README.md

Co-authored-by: James Young <[email protected]>

noroadsleft

Looks good to me.

drashna

Also, for the LEDs, when using ws2812, you could use rgblight layers, actually.

https://docs.qmk.fm/#/feature_rgblight?id=lighting-layers

keyboards/mschwingen/modelm/config.h

keyboards/mschwingen/modelm/led_ffc/rules.mk

keyboards/mschwingen/modelm/led_wired/rules.mk

keyboards/mschwingen/modelm/led_ws2812/rules.mk

keyboards/mschwingen/modelm/modelm.c

keyboards/mschwingen/modelm/rules.mk

use automatic variant defines from makefile instead of defining our own Co-authored-by: Drashna Jaelre <[email protected]>

…uart.c Co-authored-by: Drashna Jaelre <[email protected]>

mschwingen · 2020-08-21T13:34:04Z

Also, for the LEDs, when using ws2812, you could use rgblight layers, actually.

https://docs.qmk.fm/#/feature_rgblight?id=lighting-layers

I think I already replied to that - I tried, but it seems to me the rgblight layer system can't really do what I need. I want indicator LEDs that change color depending on layer, but the primary function is still num/scroll/capslock. The best I came up with is defining one layer per LED, and the turning on layers instead of LEDs - this adds unnecessary code without using any of the features from the rgblight layer.

mschwingen · 2020-08-21T13:34:59Z

Oops - sorry for the close/re-open, I meant to close the one request only.

drashna · 2020-08-22T23:01:46Z

Well, I think that you're basically doing the same thing, to be honest. Just in a slightly different way.

If you'd like, I can see converting it, if you'd like.

But for now, I'm going to merge it.

mschwingen · 2020-08-23T15:23:26Z

Well, I think that you're basically doing the same thing, to be honest. Just in a slightly different way.

If you'd like, I can see converting it, if you'd like.

Unless the rgb_layers code can provide an advantage (and reduce my own code), I'd rather leave the code as is - while I understand the urge to use common library code instead of private implementations, in my attempts, it only added code size with no gain.

But for now, I'm going to merge it.

Thanks - also for the other suggestions!

* add support for ModelM USB board * EMI improvement: remove unnecessary toggling of MOSI pin * address review comments * Update keyboards/mschwingen/modelm/rules.mk Co-authored-by: James Young <[email protected]> * Update keyboards/mschwingen/modelm/rules.mk Co-authored-by: James Young <[email protected]> * Update keyboards/mschwingen/modelm/config.h Co-authored-by: James Young <[email protected]> * Update keyboards/mschwingen/modelm/config.h Co-authored-by: James Young <[email protected]> * Update keyboards/mschwingen/modelm/rules.mk Co-authored-by: Drashna Jaelre <[email protected]> * Update keyboards/mschwingen/modelm/keymaps/default/keymap.c Co-authored-by: Drashna Jaelre <[email protected]> * update printf usage * add comment * EMI improvement: remove unnecessary toggling of MOSI signal * remove trailing space * use shorter macros as suggested in review by noroadsleft, re-format table to line up columns * Update keyboards/mschwingen/modelm/config.h Co-authored-by: Ryan <[email protected]> * Update keyboards/mschwingen/modelm/rules.mk Co-authored-by: Ryan <[email protected]> * Update keyboards/mschwingen/modelm/rules.mk Co-authored-by: Ryan <[email protected]> * Update keyboards/mschwingen/modelm/rules.mk Co-authored-by: Ryan <[email protected]> * Update keyboards/mschwingen/modelm/README.md Co-authored-by: Ryan <[email protected]> * Update keyboards/mschwingen/modelm/README.md Co-authored-by: Ryan <[email protected]> * Apply suggestions from code review use spi_read from core insteads of our own copy Co-authored-by: Ryan <[email protected]> * include spi_master.c to use spi_read() * Update keyboards/mschwingen/modelm/README.md Co-authored-by: James Young <[email protected]> * Apply suggestions from code review: correct indenting in keymap Co-authored-by: James Young <[email protected]> * Apply suggestions from code review use automatic variant defines from makefile instead of defining our own Co-authored-by: Drashna Jaelre <[email protected]> * Update keyboards/mschwingen/modelm/rules.mk: use QUANTUM_LIB_SRC for uart.c Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Michael Schwingen <[email protected]> Co-authored-by: James Young <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]>

add support for ModelM USB board

089e3ae

zvecr added the keyboard label Jul 30, 2020

drashna requested changes Aug 4, 2020

View reviewed changes

drashna requested a review from a team August 4, 2020 06:52

noroadsleft requested changes Aug 5, 2020

View reviewed changes

Michael Schwingen and others added 14 commits August 5, 2020 21:22

EMI improvement: remove unnecessary toggling of MOSI pin

af6096d

address review comments

a9cb7f1

Update keyboards/mschwingen/modelm/rules.mk

ad26a0e

Co-authored-by: James Young <[email protected]>

Update keyboards/mschwingen/modelm/rules.mk

fff835b

Co-authored-by: James Young <[email protected]>

Update keyboards/mschwingen/modelm/config.h

133eaa5

Co-authored-by: James Young <[email protected]>

Update keyboards/mschwingen/modelm/config.h

59ebdd8

Co-authored-by: James Young <[email protected]>

Update keyboards/mschwingen/modelm/rules.mk

79a591e

Co-authored-by: Drashna Jaelre <[email protected]>

Update keyboards/mschwingen/modelm/keymaps/default/keymap.c

85fa0a3

Co-authored-by: Drashna Jaelre <[email protected]>

use ______ definiton from core, re-format tables

cf2e78a

update printf usage

a9ee75f

add comment

d5c969d

EMI improvement: remove unnecessary toggling of MOSI signal

255c39f

remove trailing space

eb45afe

use shorter macros as suggested in review by noroadsleft, re-format t…

ca3ef3d

…able to line up columns

fauxpark requested changes Aug 6, 2020

View reviewed changes

mschwingen and others added 8 commits August 6, 2020 14:03

Update keyboards/mschwingen/modelm/config.h

796ae42

Co-authored-by: Ryan <[email protected]>

Update keyboards/mschwingen/modelm/rules.mk

18d4748

Co-authored-by: Ryan <[email protected]>

Update keyboards/mschwingen/modelm/rules.mk

ddcbacc

Co-authored-by: Ryan <[email protected]>

Update keyboards/mschwingen/modelm/rules.mk

9a2c572

Co-authored-by: Ryan <[email protected]>

Update keyboards/mschwingen/modelm/README.md

8a2df94

Co-authored-by: Ryan <[email protected]>

Update keyboards/mschwingen/modelm/README.md

820160f

Co-authored-by: Ryan <[email protected]>

Apply suggestions from code review

4ec0aa4

use spi_read from core insteads of our own copy Co-authored-by: Ryan <[email protected]>

include spi_master.c to use spi_read()

fc551c6

noroadsleft requested changes Aug 6, 2020

View reviewed changes

Update keyboards/mschwingen/modelm/README.md

13cdfbb

Co-authored-by: James Young <[email protected]>

Apply suggestions from code review: correct indenting in keymap

cc3c939

Co-authored-by: James Young <[email protected]>

noroadsleft approved these changes Aug 8, 2020

View reviewed changes

drashna requested changes Aug 20, 2020

View reviewed changes

mschwingen and others added 2 commits August 21, 2020 15:25

Apply suggestions from code review

e102881

use automatic variant defines from makefile instead of defining our own Co-authored-by: Drashna Jaelre <[email protected]>

Update keyboards/mschwingen/modelm/rules.mk: use QUANTUM_LIB_SRC for …

5ccbc50

…uart.c Co-authored-by: Drashna Jaelre <[email protected]>

mschwingen closed this Aug 21, 2020

mschwingen reopened this Aug 21, 2020

drashna approved these changes Aug 22, 2020

View reviewed changes

drashna merged commit 42eeb31 into qmk:master Aug 22, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add support for ModelM USB board #9846

add support for ModelM USB board #9846

mschwingen commented Jul 27, 2020

noroadsleft left a comment

drashna left a comment

mschwingen commented Aug 21, 2020

mschwingen commented Aug 21, 2020

drashna commented Aug 22, 2020

mschwingen commented Aug 23, 2020

add support for ModelM USB board #9846

add support for ModelM USB board #9846

Conversation

mschwingen commented Jul 27, 2020

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

noroadsleft left a comment

Choose a reason for hiding this comment

drashna left a comment

Choose a reason for hiding this comment

mschwingen commented Aug 21, 2020

mschwingen commented Aug 21, 2020

drashna commented Aug 22, 2020

mschwingen commented Aug 23, 2020