Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding southpaw75 keyboard #9844

Merged
merged 19 commits into from
Aug 17, 2020
Merged

adding southpaw75 keyboard #9844

merged 19 commits into from
Aug 17, 2020

Conversation

kelvinhall05
Copy link
Contributor

Description

Adding firmware for my Southpaw75 (https://www.reddit.com/r/mechmarket/comments/hoqk2f/) so it can easily be modified with the configurator, downloaded, and flashed. I've compiled and flashed the firmware using the files and default keymap found in my commit and verified it does work.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Copy link
Contributor

@ridingqwerty ridingqwerty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a readme.md with a short overview of the board that includes flashing instructions.

keyboards/southpaw75/rules.mk Outdated Show resolved Hide resolved
keyboards/southpaw75/southpaw75.h Outdated Show resolved Hide resolved
keyboards/southpaw75/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/southpaw75/config.h Outdated Show resolved Hide resolved
@ridingqwerty
Copy link
Contributor

You're also going to need an info.json if the intention is to configure this board with the QMK Configurator.

@kelvinhall05
Copy link
Contributor Author

kelvinhall05 commented Jul 27, 2020 via email

@ridingqwerty
Copy link
Contributor

ridingqwerty commented Jul 28, 2020

I have made a readme.md, please let me know if this is sufficient (file attached). Also, how should I make an info.json? What should I have in it, and how should it be formatted? Thanks! Kelvin

On Mon, Jul 27, 2020 at 3:15 PM ridingqwerty @.***> wrote: You're also going to need an info.json if the intention is to configure this board with the QMK Configurator. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#9844 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANOCB6ZV2FG2V2WQJPMUWTLR5XG4PANCNFSM4PI6REXA .

Something like this:

{
    "keyboard_name": "southpaw75",
    "url": "",
    "maintainer": "noclew",
    "width": 9,
    "height": 9
    "layouts": {
        "LAYOUT": {
            "layout": [
                {
                    "label": "NLCK",
                    "x": 0,
                    "y": 0
                },
                ... more keys here
                {
                    "label": "LCTL",
                    "x": 5,
                    "y": 8
                }
            ]
        }
    }
}

"x" and "y" are the respective 0-indexed column and row of the key with "label". If keys are more than 1u wide, you can specify a "w": parameter to indicate how wide it should be.

@kelvinhall05
Copy link
Contributor Author

I have made a readme.md, please let me know if this is sufficient (file attached). Also, how should I make an info.json? What should I have in it, and how should it be formatted? Thanks! Kelvin

On Mon, Jul 27, 2020 at 3:15 PM ridingqwerty @.***> wrote: You're also going to need an info.json if the intention is to configure this board with the QMK Configurator. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#9844 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANOCB6ZV2FG2V2WQJPMUWTLR5XG4PANCNFSM4PI6REXA .

Something like this:

{
    "keyboard_name": "southpaw75",
    "url": "",
    "maintainer": "noclew",
    "width": 9,
    "height": 9
    "layouts": {
        "LAYOUT": {
            "layout": [
                {
                    "label": "NLCK",
                    "x": 0,
                    "y": 0
                },
                ... more keys here
                {
                    "label": "LCTL",
                    "x": 5,
                    "y": 8
                }
            ]
        }
    }
}

"x" and "y" are the respective 0-indexed column and row of the key with "label". If keys are more than 1u wide, you can specify a "w": parameter to indicate how wide it should be.

I've added an info.json. Please let me know if it's done properly haha.

@kelvinhall05
Copy link
Contributor Author

Am I good to go? Haven't seen any updates in a few days.

keyboards/southpaw75/config.h Show resolved Hide resolved
keyboards/southpaw75/southpaw75.h Outdated Show resolved Hide resolved
keyboards/southpaw75/keymaps/default/keymap.c Show resolved Hide resolved
keyboards/southpaw75/southpaw75.c Show resolved Hide resolved
keyboards/southpaw75/southpaw75.h Show resolved Hide resolved
@drashna drashna requested a review from a team August 7, 2020 05:45
keyboards/southpaw75/southpaw75.h Outdated Show resolved Hide resolved
keyboards/southpaw75/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/southpaw75/readme.md Outdated Show resolved Hide resolved
keyboards/southpaw75/readme.md Outdated Show resolved Hide resolved
keyboards/southpaw75/rules.mk Outdated Show resolved Hide resolved
keyboards/southpaw75/rules.mk Outdated Show resolved Hide resolved
keyboards/southpaw75/readme.md Outdated Show resolved Hide resolved
keyboards/southpaw75/config.h Outdated Show resolved Hide resolved
Copy link
Contributor Author

@kelvinhall05 kelvinhall05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added a license to all the files that I was requested to add one to, and I've made the changes with my keymap and such. Thank you guys so much for the help, as I tried to figure most of it out myself but was clearly unable to lol.

@kelvinhall05
Copy link
Contributor Author

Sorry to bump this again but I'd really love to have this on configurator before the GB starts (August 14th). I am happy to help with anything I need to change :)

Thanks guys!

@fauxpark fauxpark mentioned this pull request Aug 12, 2020
14 tasks
@noroadsleft noroadsleft merged commit 3b3a1b2 into qmk:master Aug 17, 2020
@noroadsleft
Copy link
Member

Thanks!

nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Sep 6, 2020
* adding southpaw75

* Added readme.md for Southpaw75

* adding info.json

* Update keyboards/southpaw75/rules.mk

* Update keyboards/southpaw75/southpaw75.h

* Update keyboards/southpaw75/keymaps/default/keymap.c

* Update keyboards/southpaw75/config.h

* Update keyboards/southpaw75/southpaw75.h

* Update keyboards/southpaw75/keymaps/default/keymap.c

* Update keyboards/southpaw75/rules.mk

* Update keyboards/southpaw75/rules.mk

* Update keyboards/southpaw75/config.h

* Update keyboards/southpaw75/readme.md

* Update keyboards/southpaw75/readme.md

* Update config.h

* Update keymap.c

* Update readme.md

* Update southpaw75.c

* Update southpaw75.h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants