[Layout] - DZ60RGB V1 - Add personal configuration #9843
Conversation
| @@ -0,0 +1,6 @@ | |||
| #include QMK_KEYBOARD_H | |||
|
|
|||
| const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {[0] = LAYOUT(KC_GESC, KC_1, KC_2, KC_3, KC_4, KC_5, KC_6, KC_7, KC_8, KC_9, KC_0, KC_MINS, KC_EQL, KC_BSPC, KC_TAB, KC_Q, KC_W, KC_E, KC_R, KC_T, KC_Y, KC_U, KC_I, KC_O, KC_P, KC_LBRC, KC_RBRC, KC_BSLS, CTL_T(KC_CAPS), KC_A, KC_S, KC_D, KC_F, KC_G, KC_H, KC_J, KC_K, KC_L, KC_SCLN, KC_QUOT, KC_ENT, LSFT_T(KC_GRAVE), KC_Z, KC_X, KC_C, KC_V, KC_B, KC_N, KC_M, KC_COMM, KC_DOT, RSFT_T(KC_SLSH), KC_UP, LT(2, KC_DEL), KC_LCTL, LM(1, MOD_LALT), KC_LGUI, KC_SPC, KC_RALT, MO(1), KC_LEFT, KC_DOWN, KC_RGHT), | |||
There was a problem hiding this comment.
You may want to reformat this so ... it's readable.
There was a problem hiding this comment.
Sure! I was already seeing some other layouts had fancy named layers, that it something I'll look into. Apart from that, is there an example of a layout that is considered 'readable'?
There was a problem hiding this comment.
The default keymap for the board is a decent example.
| @@ -0,0 +1,5 @@ | |||
| #pragma once | |||
There was a problem hiding this comment.
Could you add a license header here?
| @@ -0,0 +1,6 @@ | |||
| #include QMK_KEYBOARD_H | |||
There was a problem hiding this comment.
Could you add a license header here?
There was a problem hiding this comment.
@Didel Could you run a git rebase master then git push --force-with-lease on this please? You've merged QMK's master branch into your own, and now your pull request touches a lot of files that aren't relevant to your desired changes.
|
@noroadsleft I tried to fix things, but I guess I only made them worse... I now fixed my master-branch to be equal to QMK's (which automatically closed this PR) and put all the changes in their own feature-branch, as I should have done to start with. I've created a new PR, see #9989 . It contains all the changes and requested improvements from this PR. |
Description
This adds my personal configuration so other people can use it as well. A proper documentation of all the changes is in the works for a later moment.
Types of Changes
Checklist