Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[keyboard] Fixed readme.md for reviung39 and 61. #9838

Merged
merged 23 commits into from
Aug 4, 2020
Merged

[keyboard] Fixed readme.md for reviung39 and 61. #9838

merged 23 commits into from
Aug 4, 2020

Conversation

gtips
Copy link
Contributor

@gtips gtips commented Jul 27, 2020

Description

Fixed readme.md for reviung39 and 61.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

gtips and others added 22 commits January 6, 2020 17:13
@gtips
[Keyboard] Add keyboard Reviung41
e86eb6f
@gtips
Modified files
c1aa3ea
@gtips
deleted keyboards/reviung41/keymaps/default/config.h
1569a85
@gtips
modified keyboards/rebiung41/keymaps/default/keymap.c
922eb75
@gtips
modified keyboards/reviung41/readme.md
42edbee
@gtips
modified keyboards/reviung41/readme.md
086c9d3
@gtips
modified keyboards/reviung41/readme.md
8bc5f3b
@gtips
Merge remote-tracking branch 'root_branch/master'
35a051d
@gtips
Merge remote-tracking branch 'root_branch/master'
3651ba9
@gtips
Update readme.md
57fffc8 
Change the image photo of readme.md.
@gtips
Merge branch 'master' of https://github.com/qmk/qmk_firmware
55c809a
@gtips
Merge branch 'master' of https://github.com/qmk/qmk_firmware
ad9def5
@gtips
[Keyboard] Add reviung61
6d9e900
@gtips
Update readme.md
8dc0dd7
@gtips
fix keyboards/reviung61/ and add keymap default_rgb
2aaf733
@gtips
fix keyboards/reviung61/info.json
1de30bb
@gtips
fix keyboards/reviung61/info.json
124f81d
@gtips
Merge branch 'master' of https://github.com/qmk/qmk_firmware
7fc3483
@gtips
remove keyboards/reviung61/keymaps/default/config.h
ada46a2
@gtips
Merge branch 'master' of https://github.com/qmk/qmk_firmware
e26c6f3
@gtips
Merge branch 'master' of https://github.com/qmk/qmk_firmware
e23e34e
@gtips
[keyboard] Fixed readme.md for reviung39 and 61.
5f2c4d3
@drashna
Copy link
Member

drashna commented Aug 4, 2020

Thanks!

@drashna drashna merged commit 19795a4 into qmk:master Aug 4, 2020
@drashna
Copy link
Member

drashna commented Aug 4, 2020

For future reference, we recommend against committing to your master branch as you've done here, because pull requests from modified master branches can make it more difficult to keep your QMK fork updated. It is highly recommended for QMK development – regardless of what is being done or where – to keep your master updated, but NEVER commit to it. Instead, do all your changes in a branch (branches are basically free in Git) and issue PRs from your branches when you're developing.

There are instructions on how to keep your fork updated here:

Best Practices: Your Fork's Master: Update Often, Commit Never

Fixing Your Branch will walk you through fixing up your master branch moving forward. If you need any help with this just ask.

@gtips
Copy link
Contributor Author

gtips commented Aug 5, 2020

Thanks.
I will be careful not to make a mistake next time.

nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Aug 12, 2020
@gtips @nicocesar
[Keyboard] Fixed readme.md for reviungs (qmk#9838)
067d29f 
* [Keyboard] Add keyboard Reviung41

* Modified files

* deleted keyboards/reviung41/keymaps/default/config.h

* modified keyboards/rebiung41/keymaps/default/keymap.c

* modified keyboards/reviung41/readme.md

* modified keyboards/reviung41/readme.md

* modified keyboards/reviung41/readme.md

* Update readme.md

Change the image photo of readme.md.

* [Keyboard] Add reviung61

* Update readme.md

* fix keyboards/reviung61/ and add keymap default_rgb

* fix keyboards/reviung61/info.json

* fix keyboards/reviung61/info.json

* remove keyboards/reviung61/keymaps/default/config.h

* [keyboard] Fixed readme.md for reviung39 and 61.
fcoury pushed a commit to fcoury/qmk_firmware_archive that referenced this pull request Sep 20, 2020
@gtips @fcoury
[Keyboard] Fixed readme.md for reviungs (qmk#9838)
51d2c29 
* [Keyboard] Add keyboard Reviung41

* Modified files

* deleted keyboards/reviung41/keymaps/default/config.h

* modified keyboards/rebiung41/keymaps/default/keymap.c

* modified keyboards/reviung41/readme.md

* modified keyboards/reviung41/readme.md

* modified keyboards/reviung41/readme.md

* Update readme.md

Change the image photo of readme.md.

* [Keyboard] Add reviung61

* Update readme.md

* fix keyboards/reviung61/ and add keymap default_rgb

* fix keyboards/reviung61/info.json

* fix keyboards/reviung61/info.json

* remove keyboards/reviung61/keymaps/default/config.h

* [keyboard] Fixed readme.md for reviung39 and 61.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ridingqwerty ridingqwerty ridingqwerty approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gtips @drashna @ridingqwerty