Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Update Japanese translation of feature_dip_switch.md. #9763

Merged
merged 1 commit into from
Jul 23, 2020
Merged

[Docs] Update Japanese translation of feature_dip_switch.md. #9763

merged 1 commit into from
Jul 23, 2020

Conversation

shelaf
Copy link
Contributor

@shelaf shelaf commented Jul 19, 2020

Description

Japanese documentation update.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

tag: @mtei

@mtei mtei self-requested a review July 20, 2020 08:49
mtei
mtei approved these changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@mtei mtei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

However, I am not sure that the changes in the original English text are in the correct English. (Because the original text is where I wrote it, so there may be mistakes.)

@mtei mtei requested a review from a team July 20, 2020 08:57
@mtei mtei merged commit 65f803a into qmk:master Jul 23, 2020
@mtei
Copy link
Contributor

mtei commented Jul 23, 2020

Thanks!

@shelaf shelaf deleted the ja_feature_dip_switch branch July 23, 2020 08:31
nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Aug 12, 2020
@shelaf @nicocesar
Update Japanese translation of feature_dip_switch.md. (qmk#9763)
9d45e44
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@shelaf
Update Japanese translation of feature_dip_switch.md. (qmk#9763)
6b65d0b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtei mtei mtei approved these changes

Assignees
No one assigned
Labels
documentation translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shelaf @mtei