Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Update Japanese translation of custom_quantum_functions.md. #9760

Merged
merged 2 commits into from
Jul 25, 2020
Merged

[Docs] Update Japanese translation of custom_quantum_functions.md. #9760

merged 2 commits into from
Jul 25, 2020

Conversation

shelaf
Copy link
Contributor

@shelaf shelaf commented Jul 19, 2020

Description

Japanese documentation update.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

tag: @mtei

@mtei
Copy link
Contributor

mtei commented Jul 20, 2020

@umi-umi @s-show @hsgw @satt99 @takashiski @yoshihara よかったらレビューお願いします。

@mtei mtei requested a review from noroadsleft July 20, 2020 09:29
umi-umi
umi-umi approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@umi-umi umi-umi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mtei mtei requested a review from a team July 21, 2020 16:35
@mtei
Copy link
Contributor

mtei commented Jul 23, 2020

I think this is ready to merge.

@shelaf
Update custom_quantum_functions.md
45a25dd 
fix original document version.
@mtei mtei merged commit f5c2cd2 into qmk:master Jul 25, 2020
@mtei
Copy link
Contributor

mtei commented Jul 25, 2020

Thanks!

@shelaf shelaf deleted the ja_custom_quantum_functions branch July 25, 2020 01:21
nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Aug 12, 2020
@shelaf @nicocesar
[Docs] Update Japanese translation of custom_quantum_functions.md. (q…
d173410 
…mk#9760)

* Update Japanese translation of custom_quantum_functions.md.

* Update custom_quantum_functions.md

fix original document version.
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@shelaf
[Docs] Update Japanese translation of custom_quantum_functions.md. (q…
b1bc7e8 
…mk#9760)

* Update Japanese translation of custom_quantum_functions.md.

* Update custom_quantum_functions.md

fix original document version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umi-umi umi-umi umi-umi approved these changes

@s-show s-show s-show approved these changes

@mtei mtei mtei approved these changes

@noroadsleft noroadsleft Awaiting requested review from noroadsleft

Assignees
No one assigned
Labels
documentation translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shelaf @mtei @s-show @umi-umi