Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Japanese translation of docs/other_vscode.md #9756

Merged

Conversation

umi-umi
Copy link
Contributor

@umi-umi umi-umi commented Jul 18, 2020

Description

Add a Japanese translation of docs/other_vscode.md.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@mtei
Copy link
Contributor

mtei commented Jul 18, 2020

@shelaf @s-show @hsgw @satt99 @takashiski @yoshihara よかったらレビューお願いします。

docs/ja/other_vscode.md Outdated Show resolved Hide resolved
docs/ja/other_vscode.md Outdated Show resolved Hide resolved
docs/ja/other_vscode.md Outdated Show resolved Hide resolved
docs/ja/other_vscode.md Outdated Show resolved Hide resolved
docs/ja/other_vscode.md Outdated Show resolved Hide resolved
docs/ja/other_vscode.md Outdated Show resolved Hide resolved
docs/ja/other_vscode.md Outdated Show resolved Hide resolved
docs/ja/other_vscode.md Outdated Show resolved Hide resolved
docs/ja/other_vscode.md Outdated Show resolved Hide resolved
docs/ja/other_vscode.md Outdated Show resolved Hide resolved
docs/ja/other_vscode.md Outdated Show resolved Hide resolved
docs/ja/other_vscode.md Outdated Show resolved Hide resolved
docs/ja/other_vscode.md Outdated Show resolved Hide resolved
docs/ja/other_vscode.md Outdated Show resolved Hide resolved
@mtei mtei requested a review from a team July 26, 2020 21:20
docs/ja/other_vscode.md Outdated Show resolved Hide resolved
docs/ja/other_vscode.md Outdated Show resolved Hide resolved
docs/ja/other_vscode.md Outdated Show resolved Hide resolved
@mtei mtei requested a review from a team July 30, 2020 08:34
@mtei mtei requested a review from a team July 30, 2020 10:33
@mtei
Copy link
Contributor

mtei commented Jul 30, 2020

I think this is ready to merge.

@noroadsleft noroadsleft merged commit ea3f748 into qmk:master Aug 1, 2020
@noroadsleft
Copy link
Member

ありがとうございました!

@umi-umi umi-umi deleted the other_vscode.md-japanese-translation branch August 9, 2020 09:09
nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Aug 12, 2020
* add other_vscode.md translation

* update based on comment

* update based on comment

* update based on comment
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
* add other_vscode.md translation

* update based on comment

* update based on comment

* update based on comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants