Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PocketType #9728

Merged
merged 3 commits into from
Jul 17, 2020
Merged

Add PocketType #9728

merged 3 commits into from
Jul 17, 2020

Conversation

evyd13
Copy link
Contributor

@evyd13 evyd13 commented Jul 14, 2020

Description

Adds the PocketType keyboard, a really small 12x4 ortholinear board

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added the keyboard label Jul 14, 2020
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keyboards/maartenwut/pockettype/pockettype.h Outdated Show resolved Hide resolved
keyboards/maartenwut/pockettype/pockettype.c Outdated Show resolved Hide resolved
keyboards/maartenwut/pockettype/pockettype.c Outdated Show resolved Hide resolved
keyboards/maartenwut/pockettype/keymaps/default/readme.md Outdated Show resolved Hide resolved
@zvecr zvecr requested a review from a team July 14, 2020 16:11
keyboards/maartenwut/pockettype/rules.mk Outdated Show resolved Hide resolved
keyboards/maartenwut/pockettype/rules.mk Outdated Show resolved Hide resolved
@fauxpark
Copy link
Member

Also needs a keyboard level readme

And an info.json.

@evyd13
Copy link
Contributor Author

evyd13 commented Jul 14, 2020

@fauxpark @zvecr 👍

keyboards/maartenwut/pockettype/rules.mk Outdated Show resolved Hide resolved
keyboards/maartenwut/pockettype/readme.md Outdated Show resolved Hide resolved
@fauxpark
Copy link
Member

Travis errors are unrelated.

@zvecr
Copy link
Member

zvecr commented Jul 17, 2020

Thanks!

@zvecr zvecr merged commit 4e02253 into qmk:master Jul 17, 2020
@evyd13 evyd13 deleted the pockettype branch July 17, 2020 15:42
BalzGuenat pushed a commit to BalzGuenat/qmk_firmware that referenced this pull request Jul 22, 2020
* Add Configurator layout data for LAYOUT_hotswap

* Add LAYOUT_std60_split_num0

Requested by 李小安qmk#9728 on QMK Discord.

Standard 60% ANSI layout for the alphanumeric region, with a split-0 Numpad.

Includes a sample keymap.

* Update Docs links on readme

* Change melody96.h to use #pragma once include guard

* Change config.h to use #pragma once include guard

* Add readme for default_std60_split_num0 keymap
tksgi pushed a commit to tksgi/qmk_firmware that referenced this pull request Dec 8, 2020
* Add Configurator layout data for LAYOUT_hotswap

* Add LAYOUT_std60_split_num0

Requested by 李小安qmk#9728 on QMK Discord.

Standard 60% ANSI layout for the alphanumeric region, with a split-0 Numpad.

Includes a sample keymap.

* Update Docs links on readme

* Change melody96.h to use #pragma once include guard

* Change config.h to use #pragma once include guard

* Add readme for default_std60_split_num0 keymap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants