Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QAZ Keyboard #9714

Merged
merged 25 commits into from
Jul 27, 2020
Merged

QAZ Keyboard #9714

merged 25 commits into from
Jul 27, 2020

Conversation

tominabox1
Copy link
Contributor

Description

Add QAZ Keyboard

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • [x ] My code follows the code style of this project.
  • [x ] My change requires a change to the documentation.
  • [ x] I have updated the documentation accordingly.
  • [x ] I have read the CONTRIBUTING document.
  • [x ] I have added tests to cover my changes.
  • [x ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added the keyboard label Jul 13, 2020
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My preference would be to also rename the layout macros, something like
LAYOUT_qaz to LAYOUT_split_space or LAYOUT_all and LAYOUT_qaz_big_space to LAYOUT

keyboards/qaz/config.h Outdated Show resolved Hide resolved
keyboards/qaz/rules.mk Outdated Show resolved Hide resolved
@zvecr zvecr requested a review from a team July 13, 2020 23:17
keyboards/qaz/keymaps/default/config.h Show resolved Hide resolved
keyboards/qaz/rules.mk Outdated Show resolved Hide resolved
@zvecr zvecr requested a review from a team July 17, 2020 15:43
@zvecr zvecr requested a review from fauxpark July 21, 2020 22:13
@zvecr zvecr requested a review from a team July 21, 2020 22:13
keyboards/qaz/readme.md Outdated Show resolved Hide resolved
keyboards/qaz/rules.mk Outdated Show resolved Hide resolved
tominabox1 and others added 2 commits July 25, 2020 06:19
Copy link
Contributor

@ridingqwerty ridingqwerty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to merge -- the only unapproved requested change by @noroadsleft looks to have been done.

@ridingqwerty ridingqwerty merged commit 6104609 into qmk:master Jul 27, 2020
@tominabox1 tominabox1 deleted the qaz branch July 29, 2020 01:44
@tominabox1 tominabox1 mentioned this pull request Aug 4, 2020
6 tasks
nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Aug 12, 2020
* Initial qaz commit

* Enable combos

* Improved default keymaps

* Fixed configurator json

* Via initial

* Corrected VIA json

* touch

* Via fixes

* Fixed via matrix

* Formatting

* Add lighting to qaz

* Add rgb animations, add rgb to l2, fix error in via json, enable rgblight by default

* Update QAZ readme

* Remove VIA json, prep for PR

* Correct default bootloader for pro-micro

* Remove accidentally added submodules

* Change names of layout macros

* Move combo defs to keymap folders, fix layout names in info.json

* Fixes transposition of comma and dot keys on default keymaps

* Update keyboards/qaz/keymaps/default/config.h

Co-authored-by: Joel Challis <[email protected]>

* Update keyboards/qaz/keymaps/default_big_space/config.h

Co-authored-by: Joel Challis <[email protected]>

* Update keyboards/qaz/rules.mk

Co-authored-by: Joel Challis <[email protected]>

* Update keyboards/qaz/readme.md

Co-authored-by: James Young <[email protected]>

* Update keyboards/qaz/rules.mk

Co-authored-by: James Young <[email protected]>

Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: James Young <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants