Pinky4: add via support #9711
Merged
Pinky4: add via support #9711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ingara
force-pushed
the
pinky4-via-support
branch
from
113aec6 to
ede12a9
Compare
6 tasks
zvecr
added
keyboard
keymap
via
zvecr
requested changes
Jul 17, 2020
|
Thanks for the review, @zvecr :) I based the code on the default Pinky4 keymap, so I apologize for the code not following the proper standards. It should be fixed now, though, and I've verified that it still works on my keyboard. |
fauxpark
requested changes
Jul 17, 2020
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Ryan <[email protected]>
fauxpark
approved these changes
Jul 17, 2020
noroadsleft
requested changes
Jul 22, 2020
Co-authored-by: James Young <[email protected]>
noroadsleft
approved these changes
Jul 25, 2020
|
Thanks! |
nicocesar
pushed a commit
to nicocesar/qmk_firmware
that referenced
this pull request
Aug 12, 2020
* Pinky4: add via support * Pinky4/via: simplify rules.mk * Pinky4/via: use built-in for KC_TRANS, enum for layer _names * Pinky4/via: remove redundant rules * Pinky4/via: remove unnecessary slashes * Pinky4/via: don't override default bootloader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Via support for Pinky4
Description
Added a keymap that is compiled to support configuring the keyboard through Via.
This is tested on two separate physical Pinky4 boards.
I had to change
VENDOR_ID,PRODUCT_IDandPRODUCTfrom their default values so that Via can properly identify the device.Types of Changes
Issues Fixed or Closed by This PR
Checklist