[Keyboard] add support for the kinT kinesis keyboard controller (kint2pp variant) #9687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes will be made in the next commit
zvecr
requested changes
Jul 9, 2020
fauxpark
requested changes
Jul 10, 2020
Co-authored-by: Joel Challis <[email protected]>
|
Addressed all comments, and verified the current state does indeed compile and work on my keyboard. Please take another look. Thank you! |
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
|
The PR Lint GitHub action is failing because of an unrelated issue with This should be ready to go. Please take another look. Thanks! |
drashna
reviewed
Jul 24, 2020
| @@ -136,5 +136,8 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
| #ifdef SUBPROJECT_stapelberg | |||
| #include "stapelberg/config.h" | |||
| #endif | |||
| #ifdef SUBPROJECT_kint2pp | |||
There was a problem hiding this comment.
I don't believe that these are used anymore, actually.
There was a problem hiding this comment.
Yeah, Lines 133-141 aren't needed here at all, and deleting them makes no difference to the build result.
drashna
approved these changes
Jul 24, 2020
noroadsleft
approved these changes
Jul 27, 2020
|
Thanks! |
nicocesar
pushed a commit
to nicocesar/qmk_firmware
that referenced
this pull request
Aug 12, 2020
…2pp variant) (qmk#9687) * branch keyboards/kinesis/kint2pp from keyboards/kinesis/stapelberg Changes will be made in the next commit * [Keyboard] update wiring for kinT (kint2pp variant) * add QMK plumbing * Apply zvecr’s suggestions from code review * Update keyboards/kinesis/kint2pp/config.h * Update keyboards/kinesis/kint2pp/config.h * remove superfluous config.h include
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for the kinT kinesis keyboard controller, which is a new revision of the older stapelberg controller.
See https://github.com/kinx-project/kint for the repository, https://michael.stapelberg.ch/posts/2020-07-09-kint-kinesis-keyboard-controller/ for the introduction blog post and https://youtu.be/I0kwQbnhlfk for the introduction stream, if you’re curious about more details.
I decided to send very small incremental commits in this PR for easier review: I branched keyboards/kinesis/stapelberg and then changed it to the new wiring. If you prefer to have one commit, feel free to squash and merge this PR.
Types of Changes
Checklist