Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing column for Herringbone #9679

Merged
merged 2 commits into from
Jul 10, 2020
Merged

Conversation

ramonimbao
Copy link
Contributor

Description

A Github user pointed out in an e-mail (Thanks!) that I had declared 15 columns in my matrix but only put 14 in the pins. This fixes it.

I also noticed in QMK Configurator that some keys in the F-row were 0.25 units too much the right. I edited json.info to address that.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added the keyboard label Jul 9, 2020
@zvecr zvecr requested a review from a team July 9, 2020 22:13
@zvecr zvecr merged commit 76b21a4 into qmk:master Jul 10, 2020
@zvecr
Copy link
Member

zvecr commented Jul 10, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants